Ava GUI: Several UI Fixes (#3991 )

* Fix accessability violations in ListView * Use accent colour for favourite star * Hide progress bar when its done * App Data Formating - Added space before storage unit - Changed so minutes have 0 decimals, and hours and days have 1 * Fix theming * Fix mismatched corner radius * Fix acceability violations in GridView * More consistency between Grid and List View * Fix margin * Let whitespace defocus controls
Restrict shader storage buffer search when match fails (#4011 )
2022-12-05 22:04:18 +00:00 · 2022-12-05 19:11:32 +00:00 · 2022-12-05 14:47:39 +01:00 · 2022-12-05 12:57:11 +00:00
168 changed files with 297 additions and 488 deletions
--- a/.editorconfig
+++ b/.editorconfig
@ -89,6 +89,7 @@ csharp_style_conditional_delegate_call = true:suggestion
 # Modifier preferences
 csharp_prefer_static_local_function = true:suggestion
 csharp_preferred_modifier_order = public,private,protected,internal,static,extern,new,virtual,abstract,sealed,override,readonly,unsafe,volatile,async:silent
+csharp_style_prefer_readonly_struct = true

 # Code-block preferences
 csharp_prefer_braces = true:silent
--- a/ARMeilleure/CodeGen/RegisterAllocators/AllocationResult.cs
+++ b/ARMeilleure/CodeGen/RegisterAllocators/AllocationResult.cs
@ -1,6 +1,6 @@
 namespace ARMeilleure.CodeGen.RegisterAllocators
 {
-    struct AllocationResult
+    readonly struct AllocationResult
    {
        public int IntUsedRegisters { get; }
        public int VecUsedRegisters { get; }
--- a/ARMeilleure/CodeGen/RegisterAllocators/CopyResolver.cs
+++ b/ARMeilleure/CodeGen/RegisterAllocators/CopyResolver.cs
@ -11,7 +11,7 @@ namespace ARMeilleure.CodeGen.RegisterAllocators
    {
        private class ParallelCopy
        {
-            private struct Copy
+            private readonly struct Copy
            {
                public Register Dest   { get; }
                public Register Source { get; }
--- a/ARMeilleure/CodeGen/RegisterAllocators/HybridAllocator.cs
+++ b/ARMeilleure/CodeGen/RegisterAllocators/HybridAllocator.cs
@ -11,7 +11,7 @@ namespace ARMeilleure.CodeGen.RegisterAllocators
 {
    class HybridAllocator : IRegisterAllocator
    {
-        private struct BlockInfo
+        private readonly struct BlockInfo
        {
            public bool HasCall { get; }

--- a/ARMeilleure/CodeGen/RegisterAllocators/RegisterMasks.cs
+++ b/ARMeilleure/CodeGen/RegisterAllocators/RegisterMasks.cs
@ -3,7 +3,7 @@ using System;

 namespace ARMeilleure.CodeGen.RegisterAllocators
 {
-    struct RegisterMasks
+    readonly struct RegisterMasks
    {
        public int IntAvailableRegisters   { get; }
        public int VecAvailableRegisters   { get; }
--- a/ARMeilleure/CodeGen/X86/IntrinsicInfo.cs
+++ b/ARMeilleure/CodeGen/X86/IntrinsicInfo.cs
@ -1,6 +1,6 @@
 namespace ARMeilleure.CodeGen.X86
 {
-    struct IntrinsicInfo
+    readonly struct IntrinsicInfo
    {
        public X86Instruction Inst { get; }
        public IntrinsicType  Type { get; }
--- a/ARMeilleure/Decoders/InstDescriptor.cs
+++ b/ARMeilleure/Decoders/InstDescriptor.cs
@ -2,7 +2,7 @@ using ARMeilleure.Instructions;

 namespace ARMeilleure.Decoders
 {
-    struct InstDescriptor
+    readonly struct InstDescriptor
    {
        public static InstDescriptor Undefined => new InstDescriptor(InstName.Und, InstEmit.Und);

--- a/ARMeilleure/Decoders/OpCodeTable.cs
+++ b/ARMeilleure/Decoders/OpCodeTable.cs
@ -11,7 +11,7 @@ namespace ARMeilleure.Decoders

        private const int FastLookupSize = 0x1000;

-        private struct InstInfo
+        private readonly struct InstInfo
        {
            public int Mask  { get; }
            public int Value { get; }
--- a/ARMeilleure/Diagnostics/Symbols.cs
+++ b/ARMeilleure/Diagnostics/Symbols.cs
@ -6,7 +6,7 @@ namespace ARMeilleure.Diagnostics
 {
    static class Symbols
    {
-        private struct RangedSymbol
+        private readonly struct RangedSymbol
        {
            public readonly ulong Start;
            public readonly ulong End;
--- a/ARMeilleure/IntermediateRepresentation/PhiOperation.cs
+++ b/ARMeilleure/IntermediateRepresentation/PhiOperation.cs
@ -3,7 +3,7 @@ using static ARMeilleure.IntermediateRepresentation.Operand.Factory;

 namespace ARMeilleure.IntermediateRepresentation
 {
-    struct PhiOperation
+    readonly struct PhiOperation
    {
        private readonly Operation _operation;

--- a/ARMeilleure/IntermediateRepresentation/Register.cs
+++ b/ARMeilleure/IntermediateRepresentation/Register.cs
@ -2,7 +2,7 @@ using System;

 namespace ARMeilleure.IntermediateRepresentation
 {
-    struct Register : IEquatable<Register>
+    readonly struct Register : IEquatable<Register>
    {
        public int Index { get; }

--- a/ARMeilleure/Translation/Cache/CacheEntry.cs
+++ b/ARMeilleure/Translation/Cache/CacheEntry.cs
@ -4,7 +4,7 @@ using System.Diagnostics.CodeAnalysis;

 namespace ARMeilleure.Translation.Cache
 {
-    struct CacheEntry : IComparable<CacheEntry>
+    readonly struct CacheEntry : IComparable<CacheEntry>
    {
        public int Offset { get; }
        public int Size   { get; }
--- a/ARMeilleure/Translation/Cache/CacheMemoryAllocator.cs
+++ b/ARMeilleure/Translation/Cache/CacheMemoryAllocator.cs
@ -6,7 +6,7 @@ namespace ARMeilleure.Translation.Cache
 {
    class CacheMemoryAllocator
    {
-        private struct MemoryBlock : IComparable<MemoryBlock>
+        private readonly struct MemoryBlock : IComparable<MemoryBlock>
        {
            public int Offset { get; }
            public int Size { get; }
--- a/ARMeilleure/Translation/CompilerContext.cs
+++ b/ARMeilleure/Translation/CompilerContext.cs
@ -2,7 +2,7 @@ using ARMeilleure.IntermediateRepresentation;

 namespace ARMeilleure.Translation
 {
-    struct CompilerContext
+    readonly struct CompilerContext
    {
        public ControlFlowGraph Cfg { get; }

--- a/ARMeilleure/Translation/RegisterUsage.cs
+++ b/ARMeilleure/Translation/RegisterUsage.cs
@ -14,7 +14,7 @@ namespace ARMeilleure.Translation
        private const int RegsCount = 32;
        private const int RegsMask  = RegsCount - 1;

-        private struct RegisterMask : IEquatable<RegisterMask>
+        private readonly struct RegisterMask : IEquatable<RegisterMask>
        {
            public long IntMask => Mask.GetElement(0);
            public long VecMask => Mask.GetElement(1);
--- a/ARMeilleure/Translation/Translator.cs
+++ b/ARMeilleure/Translation/Translator.cs
@ -293,7 +293,7 @@ namespace ARMeilleure.Translation
            }
        }

-        private struct Range
+        private readonly struct Range
        {
            public ulong Start { get; }
            public ulong End { get; }
--- a/Ryujinx.Audio.Backends.SoundIo/Native/libsoundio/SoundIOChannelLayout.cs
+++ b/Ryujinx.Audio.Backends.SoundIo/Native/libsoundio/SoundIOChannelLayout.cs
@ -4,7 +4,7 @@ using System.Runtime.InteropServices;

 namespace SoundIOSharp
 {
-    public struct SoundIOChannelLayout
+    public readonly struct SoundIOChannelLayout
    {
        public static int BuiltInCount
        {
--- a/Ryujinx.Audio.Backends.SoundIo/Native/libsoundio/SoundIOSampleRateRange.cs
+++ b/Ryujinx.Audio.Backends.SoundIo/Native/libsoundio/SoundIOSampleRateRange.cs
@ -1,6 +1,6 @@
 namespace SoundIOSharp
 {
-    public struct SoundIOSampleRateRange
+    public readonly struct SoundIOSampleRateRange
    {
        internal SoundIOSampleRateRange(int min, int max)
        {
--- a/Ryujinx.Ava/Assets/Styles/BaseDark.xaml
+++ b/Ryujinx.Ava/Assets/Styles/BaseDark.xaml
@ -58,5 +58,7 @@
        <Color x:Key="SystemChromeWhiteColor">#FFFFFFFF</Color>
        <Color x:Key="ThemeForegroundColor">#FFFFFFFF</Color>
        <Color x:Key="MenuFlyoutPresenterBorderColor">#3D3D3D</Color>
+        <Color x:Key="AppListBackgroundColor">#0FFFFFFF</Color>
+        <Color x:Key="AppListHoverBackgroundColor">#1EFFFFFF</Color>
    </Styles.Resources>
 </Styles>
--- a/Ryujinx.Ava/Assets/Styles/BaseLight.xaml
+++ b/Ryujinx.Ava/Assets/Styles/BaseLight.xaml
@ -50,5 +50,7 @@
        <Color x:Key="SystemChromeWhiteColor">#FFFFFFFF</Color>
        <Color x:Key="ThemeForegroundColor">#FF000000</Color>
        <Color x:Key="MenuFlyoutPresenterBorderColor">#C1C1C1</Color>
+        <Color x:Key="AppListBackgroundColor">#b3ffffff</Color>
+        <Color x:Key="AppListHoverBackgroundColor">#80cccccc</Color>
    </Styles.Resources>
 </Styles>
--- a/Ryujinx.Ava/Ui/Applet/ErrorAppletWindow.axaml
+++ b/Ryujinx.Ava/Ui/Applet/ErrorAppletWindow.axaml
@ -11,7 +11,8 @@
    Height="340"
    CanResize="False"
    SizeToContent="Height"
-    mc:Ignorable="d">
+    mc:Ignorable="d"
+    Focusable="True">
    <Grid
        Margin="20"
        HorizontalAlignment="Stretch"
--- a/Ryujinx.Ava/Ui/Applet/SwkbdAppletDialog.axaml
+++ b/Ryujinx.Ava/Ui/Applet/SwkbdAppletDialog.axaml
@ -6,7 +6,8 @@
    xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
    xmlns:window="clr-namespace:Ryujinx.Ava.Ui.Windows"
    Width="400"
-    mc:Ignorable="d">
+    mc:Ignorable="d"
+    Focusable="True">
    <Grid
        Margin="20"
        HorizontalAlignment="Stretch"
--- a/Ryujinx.Ava/Ui/Controls/GameGridView.axaml
+++ b/Ryujinx.Ava/Ui/Controls/GameGridView.axaml
@ -10,7 +10,8 @@
    xmlns:ui="clr-namespace:FluentAvalonia.UI.Controls;assembly=FluentAvalonia"
    d:DesignHeight="450"
    d:DesignWidth="800"
-    mc:Ignorable="d">
+    mc:Ignorable="d"
+    Focusable="True">
    <UserControl.Resources>
        <controls:BitmapArrayValueConverter x:Key="ByteImage" />
        <MenuFlyout x:Key="GameContextMenu" Opened="MenuBase_OnMenuOpened">
@ -113,8 +114,8 @@
                <Style Selector="ListBoxItem">
                    <Setter Property="Padding" Value="0" />
                    <Setter Property="Margin" Value="5" />
-                    <Setter Property="CornerRadius" Value="5" />
-                    <Setter Property="Background" Value="{DynamicResource SystemAccentColorDark3}" />
+                    <Setter Property="CornerRadius" Value="4" />
+                    <Setter Property="Background" Value="{DynamicResource AppListBackgroundColor}" />
                    <Style.Animations>
                        <Animation Duration="0:0:0.7">
                            <KeyFrame Cue="0%">
@ -132,27 +133,18 @@
                        </Animation>
                    </Style.Animations>
                </Style>
+                <Style Selector="ListBoxItem:selected /template/ ContentPresenter">
+                    <Setter Property="Background" Value="{DynamicResource AppListBackgroundColor}" />
+                </Style>
+                <Style Selector="ListBoxItem:pointerover /template/ ContentPresenter">
+                    <Setter Property="Background" Value="{DynamicResource AppListHoverBackgroundColor}" />
+                </Style>
            </ListBox.Styles>
            <ListBox.ItemTemplate>
                <DataTemplate>
                    <Grid>
-                        <Grid.Styles>
-                            <Style Selector="ui|SymbolIcon.small.icon">
-                                <Setter Property="FontSize" Value="15" />
-                            </Style>
-                            <Style Selector="ui|SymbolIcon.normal.icon">
-                                <Setter Property="FontSize" Value="19" />
-                            </Style>
-                            <Style Selector="ui|SymbolIcon.large.icon">
-                                <Setter Property="FontSize" Value="23" />
-                            </Style>
-                            <Style Selector="ui|SymbolIcon.huge.icon">
-                                <Setter Property="FontSize" Value="26" />
-                            </Style>
-                        </Grid.Styles>
                        <Border
-                            Margin="0"
-                            Padding="{Binding $parent[UserControl].DataContext.GridItemPadding}"
+                            Margin="10"
                            HorizontalAlignment="Stretch"
                            VerticalAlignment="Stretch"
                            Classes.huge="{Binding $parent[UserControl].DataContext.IsGridHuge}"
@ -160,57 +152,41 @@
                            Classes.normal="{Binding $parent[UserControl].DataContext.IsGridMedium}"
                            Classes.small="{Binding $parent[UserControl].DataContext.IsGridSmall}"
                            ClipToBounds="True"
-                            CornerRadius="5">
-                            <Grid Margin="0">
+                            CornerRadius="4">
+                            <Grid>
                                <Grid.RowDefinitions>
                                    <RowDefinition Height="Auto" />
                                    <RowDefinition Height="Auto" />
                                </Grid.RowDefinitions>
                                <Image
                                    Grid.Row="0"
-                                    Margin="0"
                                    HorizontalAlignment="Stretch"
                                    VerticalAlignment="Top"
                                    Source="{Binding Icon, Converter={StaticResource ByteImage}}" />
-                                <StackPanel
+                                <Panel
                                    Grid.Row="1"
                                    Height="50"
-                                    Margin="5"
+                                    Margin="0 10 0 0"
                                    HorizontalAlignment="Stretch"
                                    VerticalAlignment="Stretch"
                                    IsVisible="{Binding $parent[UserControl].DataContext.ShowNames}">
                                    <TextBlock
                                        HorizontalAlignment="Stretch"
+                                        VerticalAlignment="Center"
                                        Text="{Binding TitleName}"
                                        TextAlignment="Center"
                                        TextWrapping="Wrap" />
-                                </StackPanel>
+                                </Panel>
                            </Grid>
                        </Border>
                        <ui:SymbolIcon
-                            Margin="5"
+                            Margin="5,5,0,0"
                            HorizontalAlignment="Left"
                            VerticalAlignment="Top"
-                            Classes.huge="{Binding $parent[UserControl].DataContext.IsGridHuge}"
-                            Classes.icon="true"
-                            Classes.large="{Binding $parent[UserControl].DataContext.IsGridLarge}"
-                            Classes.normal="{Binding $parent[UserControl].DataContext.IsGridMedium}"
-                            Classes.small="{Binding $parent[UserControl].DataContext.IsGridSmall}"
-                            Foreground="Yellow"
+                            FontSize="16"
+                            Foreground="{DynamicResource SystemAccentColor}"
                            IsVisible="{Binding Favorite}"
                            Symbol="StarFilled" />
-                        <ui:SymbolIcon
-                            Margin="5"
-                            HorizontalAlignment="Left"
-                            VerticalAlignment="Top"
-                            Classes.huge="{Binding $parent[UserControl].DataContext.IsGridHuge}"
-                            Classes.icon="true"
-                            Classes.large="{Binding $parent[UserControl].DataContext.IsGridLarge}"
-                            Classes.normal="{Binding $parent[UserControl].DataContext.IsGridMedium}"
-                            Classes.small="{Binding $parent[UserControl].DataContext.IsGridSmall}"
-                            Foreground="Black"
-                            IsVisible="{Binding Favorite}"
-                            Symbol="Star" />
                    </Grid>
                </DataTemplate>
            </ListBox.ItemTemplate>
--- a/Ryujinx.Ava/Ui/Controls/GameListView.axaml
+++ b/Ryujinx.Ava/Ui/Controls/GameListView.axaml
@ -10,7 +10,8 @@
    xmlns:ui="clr-namespace:FluentAvalonia.UI.Controls;assembly=FluentAvalonia"
    d:DesignHeight="450"
    d:DesignWidth="800"
-    mc:Ignorable="d">
+    mc:Ignorable="d"
+    Focusable="True">
    <UserControl.Resources>
        <controls:BitmapArrayValueConverter x:Key="ByteImage" />
        <MenuFlyout x:Key="GameContextMenu" Opened="MenuBase_OnMenuOpened">
@ -115,8 +116,8 @@
                    <Setter Property="Padding" Value="0" />
                    <Setter Property="Margin" Value="0" />
                    <Setter Property="CornerRadius" Value="5" />
-                    <Setter Property="BorderBrush" Value="{DynamicResource SystemAccentColorDark3}" />
-                    <Setter Property="BorderThickness" Value="2" />
+                    <Setter Property="Background" Value="{DynamicResource AppListBackgroundColor}" />
+                    <Setter Property="BorderThickness" Value="2"/>
                    <Style.Animations>
                        <Animation Duration="0:0:0.7">
                            <KeyFrame Cue="0%">
@ -134,6 +135,12 @@
                        </Animation>
                    </Style.Animations>
                </Style>
+                <Style Selector="ListBoxItem:selected /template/ ContentPresenter">
+                    <Setter Property="Background" Value="{DynamicResource AppListBackgroundColor}" />
+                </Style>
+                <Style Selector="ListBoxItem:pointerover /template/ ContentPresenter">
+                    <Setter Property="Background" Value="{DynamicResource AppListHoverBackgroundColor}" />
+                </Style>
            </ListBox.Styles>
            <ListBox.ItemTemplate>
                <DataTemplate>
@ -152,9 +159,6 @@
                                    <ColumnDefinition Width="*" />
                                    <ColumnDefinition Width="Auto" />
                                </Grid.ColumnDefinitions>
-                                <Grid.RowDefinitions>
-                                    <RowDefinition />
-                                </Grid.RowDefinitions>
                                <Image
                                    Grid.RowSpan="3"
                                    Grid.Column="0"
@ -169,7 +173,7 @@
                                    HorizontalAlignment="Left"
                                    VerticalAlignment="Top"
                                    Orientation="Vertical"
-                                    Spacing="5">
+                                    Spacing="5" >
                                    <TextBlock
                                        HorizontalAlignment="Stretch"
                                        Text="{Binding TitleName}"
@ -214,20 +218,10 @@
                                    Margin="-5,-5,0,0"
                                    HorizontalAlignment="Left"
                                    VerticalAlignment="Top"
-                                    FontSize="20"
-                                    Foreground="Yellow"
+                                    FontSize="16"
+                                    Foreground="{DynamicResource SystemAccentColor}"
                                    IsVisible="{Binding Favorite}"
                                    Symbol="StarFilled" />
-                                <ui:SymbolIcon
-                                    Grid.Row="0"
-                                    Grid.Column="0"
-                                    Margin="-5,-5,0,0"
-                                    HorizontalAlignment="Left"
-                                    VerticalAlignment="Top"
-                                    FontSize="20"
-                                    Foreground="Black"
-                                    IsVisible="{Binding Favorite}"
-                                    Symbol="Star" />
                            </Grid>
                        </Border>
                    </Grid>
--- a/Ryujinx.Ava/Ui/Controls/InputDialog.axaml
+++ b/Ryujinx.Ava/Ui/Controls/InputDialog.axaml
@ -4,7 +4,8 @@
    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
    xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
    xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
-    mc:Ignorable="d">
+    mc:Ignorable="d"
+    Focusable="True">
    <Grid
        Margin="5,10,5,5"
        HorizontalAlignment="Stretch"
--- a/Ryujinx.Ava/Ui/Controls/NavigationDialogHost.axaml
+++ b/Ryujinx.Ava/Ui/Controls/NavigationDialogHost.axaml
@ -4,7 +4,8 @@
             xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
             xmlns:ui="clr-namespace:FluentAvalonia.UI.Controls;assembly=FluentAvalonia"
             mc:Ignorable="d" d:DesignWidth="800" d:DesignHeight="450"
-             x:Class="Ryujinx.Ava.Ui.Controls.NavigationDialogHost">
+             x:Class="Ryujinx.Ava.Ui.Controls.NavigationDialogHost"
+             Focusable="True">
    <ui:Frame HorizontalAlignment="Stretch" VerticalAlignment="Stretch"
              x:Name="ContentFrame" />
 </UserControl>
--- a/Ryujinx.Ava/Ui/Controls/ProfileImageSelectionDialog.axaml
+++ b/Ryujinx.Ava/Ui/Controls/ProfileImageSelectionDialog.axaml
@ -4,7 +4,8 @@
        xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
        mc:Ignorable="d"
        xmlns:Locale="clr-namespace:Ryujinx.Ava.Common.Locale"
-        x:Class="Ryujinx.Ava.Ui.Controls.ProfileImageSelectionDialog">
+        x:Class="Ryujinx.Ava.Ui.Controls.ProfileImageSelectionDialog"
+        Focusable="True">
    <Grid HorizontalAlignment="Stretch" VerticalAlignment="Center" Margin="5,10,5, 5">
        <Grid.RowDefinitions>
            <RowDefinition Height="Auto" />
--- a/Ryujinx.Ava/Ui/Controls/RendererHost.axaml
+++ b/Ryujinx.Ava/Ui/Controls/RendererHost.axaml
@ -3,5 +3,6 @@
             xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
             xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
             mc:Ignorable="d" d:DesignWidth="800" d:DesignHeight="450"
-             x:Class="Ryujinx.Ava.Ui.Controls.RendererHost">
+             x:Class="Ryujinx.Ava.Ui.Controls.RendererHost"
+             Focusable="True">
 </UserControl>
--- a/Ryujinx.Ava/Ui/Controls/SaveManager.axaml
+++ b/Ryujinx.Ava/Ui/Controls/SaveManager.axaml
@ -9,7 +9,8 @@
             mc:Ignorable="d" d:DesignWidth="800" d:DesignHeight="450"
             Height="400"
             Width="550"
-             x:Class="Ryujinx.Ava.Ui.Controls.SaveManager">
+             x:Class="Ryujinx.Ava.Ui.Controls.SaveManager"
+             Focusable="True">
    <UserControl.Resources>
        <controls:BitmapArrayValueConverter x:Key="ByteImage" />
    </UserControl.Resources>
--- a/Ryujinx.Ava/Ui/Controls/UpdateWaitWindow.axaml
+++ b/Ryujinx.Ava/Ui/Controls/UpdateWaitWindow.axaml
@ -8,7 +8,8 @@
    Title="Ryujinx - Waiting"
    SizeToContent="WidthAndHeight"
    WindowStartupLocation="CenterOwner"
-    mc:Ignorable="d">
+    mc:Ignorable="d"
+    Focusable="True">
    <Grid
        Margin="20"
        HorizontalAlignment="Stretch"
--- a/Ryujinx.Ava/Ui/Controls/UserEditor.axaml
+++ b/Ryujinx.Ava/Ui/Controls/UserEditor.axaml
@ -12,7 +12,8 @@
    Margin="0"
    MinWidth="500"
    Padding="0"
-    mc:Ignorable="d">
+    mc:Ignorable="d"
+    Focusable="True">
    <UserControl.Resources>
        <controls:BitmapArrayValueConverter x:Key="ByteImage" />
    </UserControl.Resources>
--- a/Ryujinx.Ava/Ui/Controls/UserRecoverer.axaml
+++ b/Ryujinx.Ava/Ui/Controls/UserRecoverer.axaml
@ -10,7 +10,8 @@
             xmlns:Locale="clr-namespace:Ryujinx.Ava.Common.Locale"
             xmlns:ui="clr-namespace:FluentAvalonia.UI.Controls;assembly=FluentAvalonia"
             xmlns:viewModels="clr-namespace:Ryujinx.Ava.Ui.ViewModels"
-             x:Class="Ryujinx.Ava.Ui.Controls.UserRecoverer">
+             x:Class="Ryujinx.Ava.Ui.Controls.UserRecoverer"
+             Focusable="True">
    <Design.DataContext>
        <viewModels:UserProfileViewModel />
    </Design.DataContext>
--- a/Ryujinx.Ava/Ui/Controls/UserSelector.axaml
+++ b/Ryujinx.Ava/Ui/Controls/UserSelector.axaml
@ -12,7 +12,8 @@
    d:DesignHeight="450"
    MinWidth="500"
    d:DesignWidth="800"
-    mc:Ignorable="d">
+    mc:Ignorable="d"
+    Focusable="True">
    <UserControl.Resources>
        <controls:BitmapArrayValueConverter x:Key="ByteImage" />
    </UserControl.Resources>
--- a/Ryujinx.Ava/Ui/ViewModels/MainWindowViewModel.cs
+++ b/Ryujinx.Ava/Ui/ViewModels/MainWindowViewModel.cs
@ -435,9 +435,7 @@ namespace Ryujinx.Ava.Ui.ViewModels
                OnPropertyChanged();
            }
        }
-
-        public Thickness GridItemPadding => ShowNames ? new Thickness() : new Thickness(5);
-
+        
        public bool ShowMenuAndStatusBar
        {
            get => _showMenuAndStatusBar;
@ -599,7 +597,6 @@ namespace Ryujinx.Ava.Ui.ViewModels
                ConfigurationState.Instance.Ui.ShowNames.Value = value;

                OnPropertyChanged();
-                OnPropertyChanged(nameof(GridItemPadding));
                OnPropertyChanged(nameof(GridSizeScale));

                ConfigurationState.Instance.ToFileFormat().SaveConfig(Program.ConfigurationPath);
@ -716,7 +713,6 @@ namespace Ryujinx.Ava.Ui.ViewModels
                OnPropertyChanged(nameof(IsGridLarge));
                OnPropertyChanged(nameof(IsGridHuge));
                OnPropertyChanged(nameof(ShowNames));
-                OnPropertyChanged(nameof(GridItemPadding));

                ConfigurationState.Instance.ToFileFormat().SaveConfig(Program.ConfigurationPath);
            }
@ -780,6 +776,11 @@ namespace Ryujinx.Ava.Ui.ViewModels
                {
                    _owner.LoadProgressBar.IsVisible = false;
                }
+
+                if (e.NumAppsLoaded == e.NumAppsFound)
+                {
+                    _owner.LoadProgressBar.IsVisible = false;
+                }
            });
        }

--- a/Ryujinx.Ava/Ui/Windows/AboutWindow.axaml
+++ b/Ryujinx.Ava/Ui/Windows/AboutWindow.axaml
@ -15,7 +15,8 @@
    CanResize="False"
    SizeToContent="Width"
    WindowStartupLocation="CenterOwner"
-    mc:Ignorable="d">
+    mc:Ignorable="d"
+    Focusable="True">
 	<Grid
        Margin="15"
        HorizontalAlignment="Stretch"
--- a/Ryujinx.Ava/Ui/Windows/AmiiboWindow.axaml
+++ b/Ryujinx.Ava/Ui/Windows/AmiiboWindow.axaml
@ -11,7 +11,8 @@
                        WindowStartupLocation="CenterOwner"
                        Width="800" MinHeight="650" Height="650"
                        SizeToContent="Manual"
-                        MinWidth="600">
+                        MinWidth="600"
+                        Focusable="True">
    <Design.DataContext>
        <viewModels:AmiiboWindowViewModel />
    </Design.DataContext>
--- a/Ryujinx.Ava/Ui/Windows/AvatarWindow.axaml
+++ b/Ryujinx.Ava/Ui/Windows/AvatarWindow.axaml
@ -11,7 +11,8 @@
        xmlns:viewModels="clr-namespace:Ryujinx.Ava.Ui.ViewModels"
        xmlns:controls="clr-namespace:Ryujinx.Ava.Ui.Controls"
        x:CompileBindings="True"
-        x:DataType="viewModels:AvatarProfileViewModel">
+        x:DataType="viewModels:AvatarProfileViewModel"
+        Focusable="True">
    <Design.DataContext>
        <viewModels:AvatarProfileViewModel />
    </Design.DataContext>
--- a/Ryujinx.Ava/Ui/Windows/CheatWindow.axaml
+++ b/Ryujinx.Ava/Ui/Windows/CheatWindow.axaml
@ -12,7 +12,8 @@
    MinWidth="500"
    MinHeight="500"
    WindowStartupLocation="CenterOwner"
-    mc:Ignorable="d">
+    mc:Ignorable="d"
+    Focusable="True">
    <Window.Styles>
        <Style Selector="TreeViewItem">
            <Setter Property="IsExpanded" Value="True" />
--- a/Ryujinx.Ava/Ui/Windows/ContentDialogOverlayWindow.axaml
+++ b/Ryujinx.Ava/Ui/Windows/ContentDialogOverlayWindow.axaml
@ -8,7 +8,8 @@
                        xmlns:ui="clr-namespace:FluentAvalonia.UI.Controls;assembly=FluentAvalonia"
                        x:Class="Ryujinx.Ava.Ui.Windows.ContentDialogOverlayWindow"
                        xmlns:window="clr-namespace:Ryujinx.Ava.Ui.Windows"
-                        Title="ContentDialogOverlayWindow">
+                        Title="ContentDialogOverlayWindow"
+                        Focusable="True">
    <window:StyleableWindow.Styles>
        <Style Selector="ui|ContentDialog /template/ Panel#LayoutRoot">
            <Setter Property="Background"
--- a/Ryujinx.Ava/Ui/Windows/ControllerSettingsWindow.axaml
+++ b/Ryujinx.Ava/Ui/Windows/ControllerSettingsWindow.axaml
@ -13,7 +13,8 @@
    d:DesignHeight="800"
    d:DesignWidth="800"
    x:CompileBindings="False"
-    mc:Ignorable="d">
+    mc:Ignorable="d"
+    Focusable="True">
    <Design.DataContext>
        <viewModels:ControllerSettingsViewModel />
    </Design.DataContext>
--- a/Ryujinx.Ava/Ui/Windows/DownloadableContentManagerWindow.axaml
+++ b/Ryujinx.Ava/Ui/Windows/DownloadableContentManagerWindow.axaml
@ -14,7 +14,8 @@
    MaxHeight="500"
    SizeToContent="Height"
    WindowStartupLocation="CenterOwner"
-    mc:Ignorable="d">
+    mc:Ignorable="d"
+    Focusable="True">
    <Grid Name="DownloadableContentGrid" Margin="15">
        <Grid.RowDefinitions>
            <RowDefinition Height="Auto" />
--- a/Ryujinx.Ava/Ui/Windows/IconColorPicker.cs
+++ b/Ryujinx.Ava/Ui/Windows/IconColorPicker.cs
@ -20,7 +20,7 @@ namespace Ryujinx.Ava.Ui.Windows

        private const int CutOffLuminosity = 64;

-        private struct PaletteColor
+        private readonly struct PaletteColor
        {
            public int Qck { get; }
            public byte R { get; }
--- a/Ryujinx.Ava/Ui/Windows/MainWindow.axaml
+++ b/Ryujinx.Ava/Ui/Windows/MainWindow.axaml
@ -20,7 +20,8 @@
    x:CompileBindings="True"
    x:DataType="viewModels:MainWindowViewModel"
    WindowStartupLocation="CenterScreen"
-    mc:Ignorable="d">
+    mc:Ignorable="d"
+    Focusable="True">
    <Window.Styles>
        <Style Selector="TitleBar:fullscreen">
            <Setter Property="Background" Value="#000000" />
--- a/Ryujinx.Ava/Ui/Windows/MotionSettingsWindow.axaml
+++ b/Ryujinx.Ava/Ui/Windows/MotionSettingsWindow.axaml
@ -6,7 +6,8 @@
             xmlns:ui="clr-namespace:FluentAvalonia.UI.Controls;assembly=FluentAvalonia"
             xmlns:locale="clr-namespace:Ryujinx.Ava.Common.Locale"
             mc:Ignorable="d"
-             x:Class="Ryujinx.Ava.Ui.Windows.MotionSettingsWindow">
+             x:Class="Ryujinx.Ava.Ui.Windows.MotionSettingsWindow"
+             Focusable="True">
    <Grid Margin="10">
        <Grid.RowDefinitions>
            <RowDefinition Height="Auto" />
--- a/Ryujinx.Ava/Ui/Windows/RumbleSettingsWindow.axaml
+++ b/Ryujinx.Ava/Ui/Windows/RumbleSettingsWindow.axaml
@ -6,7 +6,8 @@
             xmlns:ui="clr-namespace:FluentAvalonia.UI.Controls;assembly=FluentAvalonia"
             xmlns:locale="clr-namespace:Ryujinx.Ava.Common.Locale"
             mc:Ignorable="d"
-             x:Class="Ryujinx.Ava.Ui.Windows.RumbleSettingsWindow">
+             x:Class="Ryujinx.Ava.Ui.Windows.RumbleSettingsWindow"
+             Focusable="True">
    <Grid Margin="10">
        <Grid.RowDefinitions>
            <RowDefinition Height="Auto" />
--- a/Ryujinx.Ava/Ui/Windows/SettingsWindow.axaml
+++ b/Ryujinx.Ava/Ui/Windows/SettingsWindow.axaml
@ -18,7 +18,8 @@
    WindowStartupLocation="CenterOwner"
    x:CompileBindings="True"
    x:DataType="viewModels:SettingsViewModel"
-    mc:Ignorable="d">
+    mc:Ignorable="d"
+    Focusable="True">
    <Design.DataContext>
        <viewModels:SettingsViewModel />
    </Design.DataContext>
--- a/Ryujinx.Ava/Ui/Windows/TitleUpdateWindow.axaml
+++ b/Ryujinx.Ava/Ui/Windows/TitleUpdateWindow.axaml
@ -14,7 +14,8 @@
    MaxHeight="400"
    SizeToContent="Height"
    WindowStartupLocation="CenterOwner"
-    mc:Ignorable="d">
+    mc:Ignorable="d"
+    Focusable="True">
    <Grid Margin="15">
        <Grid.RowDefinitions>
            <RowDefinition Height="Auto" />
--- a/Ryujinx.Common/Logging/Logger.cs
+++ b/Ryujinx.Common/Logging/Logger.cs
@ -16,7 +16,7 @@ namespace Ryujinx.Common.Logging

        public static event EventHandler<LogEventArgs> Updated;

-        public struct Log
+        public readonly struct Log
        {
            internal readonly LogLevel Level;

--- a/Ryujinx.Common/Memory/SpanOrArray.cs
+++ b/Ryujinx.Common/Memory/SpanOrArray.cs
@ -7,7 +7,7 @@ namespace Ryujinx.Common.Memory
    /// This is useful to keep the Array representation when possible to avoid copies.
    /// </summary>
    /// <typeparam name="T">Element Type</typeparam>
-    public ref struct SpanOrArray<T> where T : unmanaged
+    public readonly ref struct SpanOrArray<T> where T : unmanaged
    {
        public readonly T[] Array;
        public readonly ReadOnlySpan<T> Span;
--- a/Ryujinx.Cpu/ExceptionCallbacks.cs
+++ b/Ryujinx.Cpu/ExceptionCallbacks.cs
@ -17,7 +17,7 @@ namespace Ryujinx.Cpu
    /// <summary>
    /// Stores handlers for the various CPU exceptions.
    /// </summary>
-    public struct ExceptionCallbacks
+    public readonly struct ExceptionCallbacks
    {
        /// <summary>
        /// Handler for CPU interrupts triggered using <see cref="IExecutionContext.RequestInterrupt"/>.
--- a/Ryujinx.Graphics.Device/RwCallback.cs
+++ b/Ryujinx.Graphics.Device/RwCallback.cs
@ -2,7 +2,7 @@

 namespace Ryujinx.Graphics.Device
 {
-    public struct RwCallback
+    public readonly struct RwCallback
    {
        public Action<int> Write { get; }
        public Func<int> Read { get; }
--- a/Ryujinx.Graphics.GAL/BlendDescriptor.cs
+++ b/Ryujinx.Graphics.GAL/BlendDescriptor.cs
@ -1,6 +1,6 @@
 namespace Ryujinx.Graphics.GAL
 {
-    public struct BlendDescriptor
+    public readonly struct BlendDescriptor
    {
        public bool Enable { get; }

--- a/Ryujinx.Graphics.GAL/BufferAssignment.cs
+++ b/Ryujinx.Graphics.GAL/BufferAssignment.cs
@ -1,6 +1,6 @@
 namespace Ryujinx.Graphics.GAL
 {
-    public struct BufferAssignment
+    public readonly struct BufferAssignment
    {
        public readonly int Binding;
        public readonly BufferRange Range;
--- a/Ryujinx.Graphics.GAL/BufferHandle.cs
+++ b/Ryujinx.Graphics.GAL/BufferHandle.cs
@ -1,22 +1,14 @@
-using System;
-using System.Diagnostics.CodeAnalysis;
-using System.Runtime.InteropServices;
+using System.Runtime.InteropServices;

 namespace Ryujinx.Graphics.GAL
 {
    [StructLayout(LayoutKind.Sequential, Size = 8)]
-    public struct BufferHandle : IEquatable<BufferHandle>
+    public readonly record struct BufferHandle
    {
        private readonly ulong _value;

        public static BufferHandle Null => new BufferHandle(0);

        private BufferHandle(ulong value) => _value = value;
-
-        public override bool Equals(object obj) => obj is BufferHandle handle && Equals(handle);
-        public bool Equals([AllowNull] BufferHandle other) => other._value == _value;
-        public override int GetHashCode() => _value.GetHashCode();
-        public static bool operator ==(BufferHandle left, BufferHandle right) => left.Equals(right);
-        public static bool operator !=(BufferHandle left, BufferHandle right) => !(left == right);
    }
 }
--- a/Ryujinx.Graphics.GAL/BufferRange.cs
+++ b/Ryujinx.Graphics.GAL/BufferRange.cs
@ -1,6 +1,6 @@
 namespace Ryujinx.Graphics.GAL
 {
-    public struct BufferRange
+    public readonly struct BufferRange
    {
        private static readonly BufferRange _empty = new BufferRange(BufferHandle.Null, 0, 0);

--- a/Ryujinx.Graphics.GAL/Capabilities.cs
+++ b/Ryujinx.Graphics.GAL/Capabilities.cs
@ -2,7 +2,7 @@ using Ryujinx.Graphics.Shader.Translation;

 namespace Ryujinx.Graphics.GAL
 {
-    public struct Capabilities
+    public readonly struct Capabilities
    {
        public readonly TargetApi Api;
        public readonly string VendorName;
--- a/Ryujinx.Graphics.GAL/ColorF.cs
+++ b/Ryujinx.Graphics.GAL/ColorF.cs
@ -1,32 +1,4 @@
-using System;
-
 namespace Ryujinx.Graphics.GAL
 {
-    public struct ColorF : IEquatable<ColorF>
-    {
-        public float Red   { get; }
-        public float Green { get; }
-        public float Blue  { get; }
-        public float Alpha { get; }
-
-        public ColorF(float red, float green, float blue, float alpha)
-        {
-            Red   = red;
-            Green = green;
-            Blue  = blue;
-            Alpha = alpha;
-        }
-
-        public bool Equals(ColorF color) => Red   == color.Red &&
-                                            Green == color.Green &&
-                                            Blue  == color.Blue &&
-                                            Alpha == color.Alpha;
-
-        public override bool Equals(object obj) => (obj is ColorF color) && Equals(color);
-
-        public override int GetHashCode() => HashCode.Combine(Red, Green, Blue, Alpha);
-
-        public static bool operator ==(ColorF l, ColorF r) => l.Equals(r);
-        public static bool operator !=(ColorF l, ColorF r) => !l.Equals(r);
-    }
+    public readonly record struct ColorF(float Red, float Green, float Blue, float Alpha);
 }
--- a/Ryujinx.Graphics.GAL/DepthTestDescriptor.cs
+++ b/Ryujinx.Graphics.GAL/DepthTestDescriptor.cs
@ -1,6 +1,6 @@
 namespace Ryujinx.Graphics.GAL
 {
-    public struct DepthTestDescriptor
+    public readonly struct DepthTestDescriptor
    {
        public bool TestEnable  { get; }
        public bool WriteEnable { get; }
--- a/Ryujinx.Graphics.GAL/DeviceInfo.cs
+++ b/Ryujinx.Graphics.GAL/DeviceInfo.cs
@ -1,6 +1,6 @@
 namespace Ryujinx.Graphics.GAL
 {
-    public struct DeviceInfo
+    public readonly struct DeviceInfo
    {
        public readonly string Id;
        public readonly string Vendor;
--- a/Ryujinx.Graphics.GAL/Extents2D.cs
+++ b/Ryujinx.Graphics.GAL/Extents2D.cs
@ -2,7 +2,7 @@ using Ryujinx.Common;

 namespace Ryujinx.Graphics.GAL
 {
-    public struct Extents2D
+    public readonly struct Extents2D
    {
        public int X1 { get; }
        public int Y1 { get; }
--- a/Ryujinx.Graphics.GAL/Extents2DF.cs
+++ b/Ryujinx.Graphics.GAL/Extents2DF.cs
@ -1,6 +1,6 @@
 namespace Ryujinx.Graphics.GAL
 {
-    public struct Extents2DF
+    public readonly struct Extents2DF
    {
        public float X1 { get; }
        public float Y1 { get; }
--- a/Ryujinx.Graphics.GAL/HardwareInfo.cs
+++ b/Ryujinx.Graphics.GAL/HardwareInfo.cs
@ -1,6 +1,6 @@
 namespace Ryujinx.Graphics.GAL
 {
-    public struct HardwareInfo
+    public readonly struct HardwareInfo
    {
        public string GpuVendor { get; }
        public string GpuModel { get; }
--- a/Ryujinx.Graphics.GAL/ImageCrop.cs
+++ b/Ryujinx.Graphics.GAL/ImageCrop.cs
@ -1,6 +1,6 @@
 namespace Ryujinx.Graphics.GAL
 {
-    public struct ImageCrop
+    public readonly struct ImageCrop
    {
        public int   Left         { get; }
        public int   Right        { get; }
--- a/Ryujinx.Graphics.GAL/MultisampleDescriptor.cs
+++ b/Ryujinx.Graphics.GAL/MultisampleDescriptor.cs
@ -1,6 +1,6 @@
 namespace Ryujinx.Graphics.GAL
 {
-    public struct MultisampleDescriptor
+    public readonly struct MultisampleDescriptor
    {
        public bool AlphaToCoverageEnable { get; }
        public bool AlphaToCoverageDitherEnable { get; }
--- a/Ryujinx.Graphics.GAL/ProgramPipelineState.cs
+++ b/Ryujinx.Graphics.GAL/ProgramPipelineState.cs
@ -6,7 +6,7 @@ namespace Ryujinx.Graphics.GAL
    /// <summary>
    /// Descriptor for a pipeline buffer binding.
    /// </summary>
-    public struct BufferPipelineDescriptor
+    public readonly struct BufferPipelineDescriptor
    {
        public bool Enable { get; }
        public int Stride { get; }
--- a/Ryujinx.Graphics.GAL/Rectangle.cs
+++ b/Ryujinx.Graphics.GAL/Rectangle.cs
@ -1,6 +1,6 @@
 namespace Ryujinx.Graphics.GAL
 {
-    public struct Rectangle<T> where T : unmanaged
+    public readonly struct Rectangle<T> where T : unmanaged
    {
        public T X { get; }
        public T Y { get; }
--- a/Ryujinx.Graphics.GAL/SamplerCreateInfo.cs
+++ b/Ryujinx.Graphics.GAL/SamplerCreateInfo.cs
@ -1,6 +1,6 @@
 namespace Ryujinx.Graphics.GAL
 {
-    public struct SamplerCreateInfo
+    public readonly struct SamplerCreateInfo
    {
        public MinFilter MinFilter { get; }
        public MagFilter MagFilter { get; }
--- a/Ryujinx.Graphics.GAL/ScreenCaptureImageInfo.cs
+++ b/Ryujinx.Graphics.GAL/ScreenCaptureImageInfo.cs
@ -1,6 +1,6 @@
 namespace Ryujinx.Graphics.GAL
 {
-    public struct ScreenCaptureImageInfo
+    public readonly struct ScreenCaptureImageInfo
    {
        public ScreenCaptureImageInfo(int width, int height, bool isBgra, byte[] data, bool flipX, bool flipY)
        {
--- a/Ryujinx.Graphics.GAL/ShaderBindings.cs
+++ b/Ryujinx.Graphics.GAL/ShaderBindings.cs
@ -2,7 +2,7 @@

 namespace Ryujinx.Graphics.GAL
 {
-    public struct ShaderBindings
+    public readonly struct ShaderBindings
    {
        public IReadOnlyCollection<int> UniformBufferBindings { get; }
        public IReadOnlyCollection<int> StorageBufferBindings { get; }
--- a/Ryujinx.Graphics.GAL/ShaderSource.cs
+++ b/Ryujinx.Graphics.GAL/ShaderSource.cs
@ -3,7 +3,7 @@ using Ryujinx.Graphics.Shader.Translation;

 namespace Ryujinx.Graphics.GAL
 {
-    public struct ShaderSource
+    public readonly struct ShaderSource
    {
        public string Code { get; }
        public byte[] BinaryCode { get; }
--- a/Ryujinx.Graphics.GAL/StencilTestDescriptor.cs
+++ b/Ryujinx.Graphics.GAL/StencilTestDescriptor.cs
@ -1,6 +1,6 @@
 namespace Ryujinx.Graphics.GAL
 {
-    public struct StencilTestDescriptor
+    public readonly struct StencilTestDescriptor
    {
        public bool TestEnable { get; }

--- a/Ryujinx.Graphics.GAL/TextureCreateInfo.cs
+++ b/Ryujinx.Graphics.GAL/TextureCreateInfo.cs
@ -4,7 +4,7 @@ using System.Numerics;

 namespace Ryujinx.Graphics.GAL
 {
-    public struct TextureCreateInfo : IEquatable<TextureCreateInfo>
+    public readonly struct TextureCreateInfo : IEquatable<TextureCreateInfo>
    {
        public int Width         { get; }
        public int Height        { get; }
@ -62,42 +62,42 @@ namespace Ryujinx.Graphics.GAL
            SwizzleA         = swizzleA;
        }

-        public readonly int GetMipSize(int level)
+        public int GetMipSize(int level)
        {
            return GetMipStride(level) * GetLevelHeight(level) * GetLevelDepth(level);
        }

-        public readonly int GetMipSize2D(int level)
+        public int GetMipSize2D(int level)
        {
            return GetMipStride(level) * GetLevelHeight(level);
        }

-        public readonly int GetMipStride(int level)
+        public int GetMipStride(int level)
        {
            return BitUtils.AlignUp(GetLevelWidth(level) * BytesPerPixel, 4);
        }

-        private readonly int GetLevelWidth(int level)
+        private int GetLevelWidth(int level)
        {
            return BitUtils.DivRoundUp(GetLevelSize(Width, level), BlockWidth);
        }

-        private readonly int GetLevelHeight(int level)
+        private int GetLevelHeight(int level)
        {
            return BitUtils.DivRoundUp(GetLevelSize(Height, level), BlockHeight);
        }

-        private readonly int GetLevelDepth(int level)
+        private int GetLevelDepth(int level)
        {
            return Target == Target.Texture3D ? GetLevelSize(Depth, level) : GetLayers();
        }

-        public readonly int GetDepthOrLayers()
+        public int GetDepthOrLayers()
        {
            return Target == Target.Texture3D ? Depth : GetLayers();
        }

-        public readonly int GetLayers()
+        public int GetLayers()
        {
            if (Target == Target.Texture2DArray ||
                Target == Target.Texture2DMultisampleArray ||
@ -113,7 +113,7 @@ namespace Ryujinx.Graphics.GAL
            return 1;
        }

-        public readonly int GetLevelsClamped()
+        public int GetLevelsClamped()
        {
            int maxSize = Width;

--- a/Ryujinx.Graphics.GAL/VertexAttribDescriptor.cs
+++ b/Ryujinx.Graphics.GAL/VertexAttribDescriptor.cs
@ -1,40 +1,4 @@
-using System;
-
 namespace Ryujinx.Graphics.GAL
 {
-    public struct VertexAttribDescriptor : IEquatable<VertexAttribDescriptor>
-    {
-        public int BufferIndex { get; }
-        public int Offset      { get; }
-
-        public bool IsZero { get; }
-
-        public Format Format { get; }
-
-        public VertexAttribDescriptor(int bufferIndex, int offset, bool isZero, Format format)
-        {
-            BufferIndex = bufferIndex;
-            Offset      = offset;
-            IsZero      = isZero;
-            Format      = format;
-        }
-
-        public override bool Equals(object obj)
-        {
-            return obj is VertexAttribDescriptor other && Equals(other);
-        }
-
-        public bool Equals(VertexAttribDescriptor other)
-        {
-            return BufferIndex == other.BufferIndex &&
-                   Offset      == other.Offset &&
-                   IsZero      == other.IsZero &&
-                   Format      == other.Format;
-        }
-
-        public override int GetHashCode()
-        {
-            return HashCode.Combine(BufferIndex, Offset, IsZero, Format);
-        }
-    }
+    public readonly record struct VertexAttribDescriptor(int BufferIndex, int Offset, bool IsZero, Format Format);
 }
--- a/Ryujinx.Graphics.GAL/VertexBufferDescriptor.cs
+++ b/Ryujinx.Graphics.GAL/VertexBufferDescriptor.cs
@ -1,6 +1,6 @@
 namespace Ryujinx.Graphics.GAL
 {
-    public struct VertexBufferDescriptor
+    public readonly struct VertexBufferDescriptor
    {
        public BufferRange Buffer { get; }

--- a/Ryujinx.Graphics.GAL/Viewport.cs
+++ b/Ryujinx.Graphics.GAL/Viewport.cs
@ -1,6 +1,6 @@
 namespace Ryujinx.Graphics.GAL
 {
-    public struct Viewport
+    public readonly struct Viewport
    {
        public Rectangle<float> Region { get; }

--- a/Ryujinx.Graphics.Gpu/Engine/MME/IMacroEE.cs
+++ b/Ryujinx.Graphics.Gpu/Engine/MME/IMacroEE.cs
@ -7,7 +7,7 @@ namespace Ryujinx.Graphics.Gpu.Engine.MME
    /// <summary>
    /// FIFO word.
    /// </summary>
-    struct FifoWord
+    readonly struct FifoWord
    {
        /// <summary>
        /// GPU virtual address where the word is located in memory.
--- a/Ryujinx.Graphics.Gpu/Engine/MME/MacroHLETable.cs
+++ b/Ryujinx.Graphics.Gpu/Engine/MME/MacroHLETable.cs
@ -13,7 +13,7 @@ namespace Ryujinx.Graphics.Gpu.Engine.MME
        /// <summary>
        /// Macroo High-level implementation table entry.
        /// </summary>
-        struct TableEntry
+        readonly struct TableEntry
        {
            /// <summary>
            /// Name of the Macro function.
--- a/Ryujinx.Graphics.Gpu/Engine/Threed/StateUpdateTracker.cs
+++ b/Ryujinx.Graphics.Gpu/Engine/Threed/StateUpdateTracker.cs
@ -11,7 +11,7 @@ namespace Ryujinx.Graphics.Gpu.Engine.Threed
    /// <summary>
    /// State update callback entry, with the callback function and associated field names.
    /// </summary>
-    struct StateUpdateCallbackEntry
+    readonly struct StateUpdateCallbackEntry
    {
        /// <summary>
        /// Callback function, to be called if the register was written as the state needs to be updated.
--- a/Ryujinx.Graphics.Gpu/Image/FormatInfo.cs
+++ b/Ryujinx.Graphics.Gpu/Image/FormatInfo.cs
@ -5,7 +5,7 @@ namespace Ryujinx.Graphics.Gpu.Image
    /// <summary>
    /// Represents texture format information.
    /// </summary>
-    struct FormatInfo
+    readonly struct FormatInfo
    {
        /// <summary>
        /// A default, generic RGBA8 texture format.
--- a/Ryujinx.Graphics.Gpu/Image/TextureBindingInfo.cs
+++ b/Ryujinx.Graphics.Gpu/Image/TextureBindingInfo.cs
@ -7,7 +7,7 @@ namespace Ryujinx.Graphics.Gpu.Image
    /// Texture binding information.
    /// This is used for textures that needs to be accessed from shaders.
    /// </summary>
-    struct TextureBindingInfo
+    readonly struct TextureBindingInfo
    {
        /// <summary>
        /// Shader sampler target type.
--- a/Ryujinx.Graphics.Gpu/Image/TextureCache.cs
+++ b/Ryujinx.Graphics.Gpu/Image/TextureCache.cs
@ -16,7 +16,7 @@ namespace Ryujinx.Graphics.Gpu.Image
    /// </summary>
    class TextureCache : IDisposable
    {
-        private struct OverlapInfo
+        private readonly struct OverlapInfo
        {
            public TextureViewCompatibility Compatibility { get; }
            public int FirstLayer { get; }
--- a/Ryujinx.Graphics.Gpu/Image/TextureGroup.cs
+++ b/Ryujinx.Graphics.Gpu/Image/TextureGroup.cs
@ -14,7 +14,7 @@ namespace Ryujinx.Graphics.Gpu.Image
    /// <summary>
    /// An overlapping texture group with a given view compatibility.
    /// </summary>
-    struct TextureIncompatibleOverlap
+    readonly struct TextureIncompatibleOverlap
    {
        public readonly TextureGroup Group;
        public readonly TextureViewCompatibility Compatibility;
--- a/Ryujinx.Graphics.Gpu/Image/TextureInfo.cs
+++ b/Ryujinx.Graphics.Gpu/Image/TextureInfo.cs
@ -6,7 +6,7 @@ namespace Ryujinx.Graphics.Gpu.Image
    /// <summary>
    /// Texture information.
    /// </summary>
-    struct TextureInfo
+    readonly struct TextureInfo
    {
        /// <summary>
        /// Address of the texture in GPU mapped memory.
--- a/Ryujinx.Graphics.Gpu/Memory/BufferBounds.cs
+++ b/Ryujinx.Graphics.Gpu/Memory/BufferBounds.cs
@ -5,7 +5,7 @@ namespace Ryujinx.Graphics.Gpu.Memory
    /// <summary>
    /// Memory range used for buffers.
    /// </summary>
-    struct BufferBounds
+    readonly struct BufferBounds
    {
        /// <summary>
        /// Region virtual address.
--- a/Ryujinx.Graphics.Gpu/Memory/BufferTextureBinding.cs
+++ b/Ryujinx.Graphics.Gpu/Memory/BufferTextureBinding.cs
@ -7,7 +7,7 @@ namespace Ryujinx.Graphics.Gpu.Memory
    /// <summary>
    /// A buffer binding to apply to a buffer texture.
    /// </summary>
-    struct BufferTextureBinding
+    readonly struct BufferTextureBinding
    {
        /// <summary>
        /// Shader stage accessing the texture.
--- a/Ryujinx.Graphics.Gpu/Memory/CounterCache.cs
+++ b/Ryujinx.Graphics.Gpu/Memory/CounterCache.cs
@ -8,7 +8,7 @@ namespace Ryujinx.Graphics.Gpu.Memory
    /// </summary>
    class CounterCache
    {
-        private struct CounterEntry
+        private readonly struct CounterEntry
        {
            public ulong Address { get; }
            public ICounterEvent Event { get; }
--- a/Ryujinx.Graphics.Gpu/Shader/DiskCache/BackgroundDiskCacheWriter.cs
+++ b/Ryujinx.Graphics.Gpu/Shader/DiskCache/BackgroundDiskCacheWriter.cs
@ -24,7 +24,7 @@ namespace Ryujinx.Graphics.Gpu.Shader.DiskCache
        /// <summary>
        /// Represents an operation to perform on the <see cref="_fileWriterWorkerQueue"/>.
        /// </summary>
-        private struct CacheFileOperationTask
+        private readonly struct CacheFileOperationTask
        {
            /// <summary>
            /// The type of operation to perform.
@ -46,7 +46,7 @@ namespace Ryujinx.Graphics.Gpu.Shader.DiskCache
        /// <summary>
        /// Background shader cache write information.
        /// </summary>
-        private struct AddShaderData
+        private readonly struct AddShaderData
        {
            /// <summary>
            /// Cached shader program.
--- a/Ryujinx.Graphics.Gpu/Shader/DiskCache/DiskCacheHostStorage.cs
+++ b/Ryujinx.Graphics.Gpu/Shader/DiskCache/DiskCacheHostStorage.cs
@ -22,7 +22,7 @@ namespace Ryujinx.Graphics.Gpu.Shader.DiskCache
        private const ushort FileFormatVersionMajor = 1;
        private const ushort FileFormatVersionMinor = 2;
        private const uint FileFormatVersionPacked = ((uint)FileFormatVersionMajor << 16) | FileFormatVersionMinor;
-        private const uint CodeGenVersion = 3957;
+        private const uint CodeGenVersion = 4011;

        private const string SharedTocFileName = "shared.toc";
        private const string SharedDataFileName = "shared.data";
--- a/Ryujinx.Graphics.Gpu/Shader/DiskCache/GuestCodeAndCbData.cs
+++ b/Ryujinx.Graphics.Gpu/Shader/DiskCache/GuestCodeAndCbData.cs
@ -3,7 +3,7 @@ namespace Ryujinx.Graphics.Gpu.Shader.DiskCache
    /// <summary>
    /// Guest shader code and constant buffer data accessed by the shader.
    /// </summary>
-    struct GuestCodeAndCbData
+    readonly struct GuestCodeAndCbData
    {
        /// <summary>
        /// Maxwell binary shader code.
--- a/Ryujinx.Graphics.Gpu/Shader/DiskCache/ParallelDiskCacheLoader.cs
+++ b/Ryujinx.Graphics.Gpu/Shader/DiskCache/ParallelDiskCacheLoader.cs
@ -37,7 +37,7 @@ namespace Ryujinx.Graphics.Gpu.Shader.DiskCache
        /// <summary>
        /// Program validation entry.
        /// </summary>
-        private struct ProgramEntry
+        private readonly struct ProgramEntry
        {
            /// <summary>
            /// Cached shader program.
@ -90,7 +90,7 @@ namespace Ryujinx.Graphics.Gpu.Shader.DiskCache
        /// <summary>
        /// Translated shader compilation entry.
        /// </summary>
-        private struct ProgramCompilation
+        private readonly struct ProgramCompilation
        {
            /// <summary>
            /// Translated shader stages.
@ -143,7 +143,7 @@ namespace Ryujinx.Graphics.Gpu.Shader.DiskCache
        /// <summary>
        /// Program translation entry.
        /// </summary>
-        private struct AsyncProgramTranslation
+        private readonly struct AsyncProgramTranslation
        {
            /// <summary>
            /// Guest code for each active stage.
--- a/Ryujinx.Graphics.Gpu/Shader/GpuChannelComputeState.cs
+++ b/Ryujinx.Graphics.Gpu/Shader/GpuChannelComputeState.cs
@ -3,7 +3,7 @@ namespace Ryujinx.Graphics.Gpu.Shader
    /// <summary>
    /// State used by the <see cref="GpuAccessor"/>.
    /// </summary>
-    struct GpuChannelComputeState
+    readonly struct GpuChannelComputeState
    {
        // New fields should be added to the end of the struct to keep disk shader cache compatibility.

--- a/Ryujinx.Graphics.Gpu/Shader/GpuChannelPoolState.cs
+++ b/Ryujinx.Graphics.Gpu/Shader/GpuChannelPoolState.cs
@ -5,7 +5,7 @@ namespace Ryujinx.Graphics.Gpu.Shader
    /// <summary>
    /// State used by the <see cref="GpuAccessor"/>.
    /// </summary>
-    struct GpuChannelPoolState : IEquatable<GpuChannelPoolState>
+    readonly struct GpuChannelPoolState : IEquatable<GpuChannelPoolState>
    {
        /// <summary>
        /// GPU virtual address of the texture pool.
--- a/Ryujinx.Graphics.Gpu/Shader/HashTable/PartitionedHashTable.cs
+++ b/Ryujinx.Graphics.Gpu/Shader/HashTable/PartitionedHashTable.cs
@ -13,7 +13,7 @@ namespace Ryujinx.Graphics.Gpu.Shader.HashTable
        /// <summary>
        /// Entry for a given data size.
        /// </summary>
-        private struct SizeEntry
+        private readonly struct SizeEntry
        {
            /// <summary>
            /// Size for the data that will be stored on the hash table on this entry.
--- a/Ryujinx.Graphics.Gpu/Shader/ShaderCache.cs
+++ b/Ryujinx.Graphics.Gpu/Shader/ShaderCache.cs
@ -26,7 +26,7 @@ namespace Ryujinx.Graphics.Gpu.Shader
        /// </summary>
        public const TranslationFlags DefaultFlags = TranslationFlags.DebugMode;

-        private struct TranslatedShader
+        private readonly struct TranslatedShader
        {
            public readonly CachedShaderStage Shader;
            public readonly ShaderProgram Program;
@ -38,7 +38,7 @@ namespace Ryujinx.Graphics.Gpu.Shader
            }
        }

-        private struct TranslatedShaderVertexPair
+        private readonly struct TranslatedShaderVertexPair
        {
            public readonly CachedShaderStage VertexA;
            public readonly CachedShaderStage VertexB;
@ -59,7 +59,7 @@ namespace Ryujinx.Graphics.Gpu.Shader
        private readonly Dictionary<ulong, CachedShaderProgram> _cpPrograms;
        private readonly Dictionary<ShaderAddresses, CachedShaderProgram> _gpPrograms;

-        private struct ProgramToSave
+        private readonly struct ProgramToSave
        {
            public readonly CachedShaderProgram CachedProgram;
            public readonly IProgram HostProgram;
--- a/Ryujinx.Graphics.Gpu/Shader/ShaderCodeAccessor.cs
+++ b/Ryujinx.Graphics.Gpu/Shader/ShaderCodeAccessor.cs
@ -7,7 +7,7 @@ namespace Ryujinx.Graphics.Gpu.Shader
    /// <summary>
    /// Shader code accessor.
    /// </summary>
-    struct ShaderCodeAccessor : IDataAccessor
+    readonly struct ShaderCodeAccessor : IDataAccessor
    {
        private readonly MemoryManager _memoryManager;
        private readonly ulong _baseAddress;
--- a/Ryujinx.Graphics.Gpu/Shader/ShaderDumpPaths.cs
+++ b/Ryujinx.Graphics.Gpu/Shader/ShaderDumpPaths.cs
@ -5,7 +5,7 @@ namespace Ryujinx.Graphics.Gpu.Shader
    /// <summary>
    /// Paths where shader code was dumped on disk.
    /// </summary>
-    struct ShaderDumpPaths
+    readonly struct ShaderDumpPaths
    {
        /// <summary>
        /// Path where the full shader code with header was dumped, or null if not dumped.
--- a/Ryujinx.Graphics.Gpu/Shader/ShaderSpecializationState.cs
+++ b/Ryujinx.Graphics.Gpu/Shader/ShaderSpecializationState.cs
@ -121,7 +121,7 @@ namespace Ryujinx.Graphics.Gpu.Shader
        /// <summary>
        /// Texture binding information, used to identify each texture accessed by the shader.
        /// </summary>
-        private struct TextureKey : IEquatable<TextureKey>
+        private readonly record struct TextureKey
        {
            // New fields should be added to the end of the struct to keep disk shader cache compatibility.

@ -152,21 +152,6 @@ namespace Ryujinx.Graphics.Gpu.Shader
                Handle = handle;
                CbufSlot = cbufSlot;
            }
-
-            public override bool Equals(object obj)
-            {
-                return obj is TextureKey textureKey && Equals(textureKey);
-            }
-
-            public bool Equals(TextureKey other)
-            {
-                return StageIndex == other.StageIndex && Handle == other.Handle && CbufSlot == other.CbufSlot;
-            }
-
-            public override int GetHashCode()
-            {
-                return HashCode.Combine(StageIndex, Handle, CbufSlot);
-            }
        }

        private readonly Dictionary<TextureKey, Box<TextureSpecializationState>> _textureSpecialization;
--- a/Ryujinx.Graphics.Gpu/Window.cs
+++ b/Ryujinx.Graphics.Gpu/Window.cs
@ -20,7 +20,7 @@ namespace Ryujinx.Graphics.Gpu
        /// <summary>
        /// Texture presented on the window.
        /// </summary>
-        private struct PresentationTexture
+        private readonly struct PresentationTexture
        {
            /// <summary>
            /// Texture cache where the texture might be located.
--- a/Ryujinx.Graphics.Host1x/Host1xDevice.cs
+++ b/Ryujinx.Graphics.Host1x/Host1xDevice.cs
@ -9,7 +9,7 @@ namespace Ryujinx.Graphics.Host1x
 {
    public sealed class Host1xDevice : IDisposable
    {
-        private struct Command
+        private readonly struct Command
        {
            public int[] Buffer { get; }
            public long ContextId { get; }
--- a/Ryujinx.Graphics.Host1x/SyncptIncrManager.cs
+++ b/Ryujinx.Graphics.Host1x/SyncptIncrManager.cs
@ -7,7 +7,7 @@ namespace Ryujinx.Graphics.Host1x
    {
        private readonly SynchronizationManager _syncMgr;

-        private struct SyncptIncr
+        private readonly struct SyncptIncr
        {
            public uint Id { get; }
            public ClassId ClassId { get; }
--- a/Show More
+++ b/Show More
Author	SHA1	Message	Date
Isaac Marovitz	121296834a	Ava GUI: Several UI Fixes (#3991 ) * Fix accessability violations in ListView * Use accent colour for favourite star * Hide progress bar when its done * App Data Formating - Added space before storage unit - Changed so minutes have 0 decimals, and hours and days have 1 * Fix theming * Fix mismatched corner radius * Fix acceability violations in GridView * More consistency between Grid and List View * Fix margin * Let whitespace defocus controls	2022-12-05 22:04:18 +00:00
gdkchan	bbb24d8c7e	Restrict shader storage buffer search when match fails (#4011 ) * Restrict storage buffer search when match fails * Shader cache version bump	2022-12-05 19:11:32 +00:00
Andrey Sukharev	4da44e09cb	Make structs readonly when applicable (#4002 ) * Make all structs readonly when applicable. It should reduce amount of needless defensive copies * Make structs with trivial boilerplate equality code record structs * Remove unnecessary readonly modifiers from TextureCreateInfo * Make BitMap structs readonly too	2022-12-05 14:47:39 +01:00
Mary-nyan	ae13f0ab4d	misc: Fix obsolete warnings in Ryujinx.Graphics.Vulkan (#4020 ) Was caused by some merges after the Silk.NET update	2022-12-05 12:57:11 +00:00