From 19f8c54b571ed5a56c637f7c782c5b51b09a8d13 Mon Sep 17 00:00:00 2001
From: Menno van Leeuwen <menno@vleeuwen.me>
Date: Mon, 11 Nov 2024 14:41:51 +0100
Subject: [PATCH] refactor: update Docker workflow and configuration for
 clarity and consistency

---
 .github/workflows/docker-publish.yml |  3 ---
 README.md                            |  2 +-
 docker-compose.yml                   | 11 +++++++----
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/docker-publish.yml b/.github/workflows/docker-publish.yml
index afcafb1..47cd214 100644
--- a/.github/workflows/docker-publish.yml
+++ b/.github/workflows/docker-publish.yml
@@ -4,10 +4,7 @@ on:
   release:
     types: [published]
   push:
-    branches: [ "main" ]
     tags: [ 'v*.*.*' ]
-  pull_request:
-    branches: [ "main" ]
 
 env:
   IMAGE_NAME: ${{ github.repository }}
diff --git a/README.md b/README.md
index 0a455d6..267a696 100644
--- a/README.md
+++ b/README.md
@@ -19,7 +19,7 @@ services:
     image: ghcr.io/vleeuwenmenno/auto-upnp:latest
     network_mode: host
     environment:
-      - PORTS=[{"port": 80, "protocol": "tcp"}, {"port": 443, "protocol": "tcp"}]
+      PORTS: [{"port": 80, "protocol": "tcp"}, {"port": 443, "protocol": "tcp"}]
 ```
 
 ### Environment Variables
diff --git a/docker-compose.yml b/docker-compose.yml
index f81a025..19748f9 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -1,14 +1,17 @@
 name: auto-upnp
 services:
   upnp:
-    # image: ghcr.io/vleeuwenmenno/auto-upnp:latest
-    build:
-      context: .
-      dockerfile: Dockerfile
+    image: ghcr.io/vleeuwenmenno/auto-upnp:latest
+    # build:
+    #   context: .
+    #   dockerfile: Dockerfile
     restart: unless-stopped
     network_mode: host
     environment:
       UPNP_DURATION: 86400  # 24 hours in seconds
+      # One-liner
+      # PORTS: [{"port": 80, "protocol": "tcp"}, {"port": 443, "protocol": "tcp"}]
+      # Or multi-line
       PORTS: | 
         [
           {"port": 7777, "protocol": "udp"},