[Ryujinx.Tests] Address dotnet-format issues (#5389)

* dotnet format style --severity info

Some changes were manually reverted.

* dotnet format analyzers --serverity info

Some changes have been minimally adapted.

* Restore a few unused methods and variables

* Fix new dotnet-format issues after rebase

* Address review comments

* Address most dotnet format whitespace warnings

* Apply dotnet format whitespace formatting

A few of them have been manually reverted and the corresponding warning was silenced

* Format if-blocks correctly

* Run dotnet format after rebase and remove unused usings

- analyzers
- style
- whitespace

* Add comments to disabled warnings

* Simplify properties and array initialization, Use const when possible, Remove trailing commas

* cpu tests: Disable CA2211 for CodeBaseAddress and DataBaseAddress

* Revert "Simplify properties and array initialization, Use const when possible, Remove trailing commas"

This reverts commit 9462e4136c0a2100dc28b20cf9542e06790aa67e.

* dotnet format whitespace after rebase

* Apply suggestions from code review

Co-authored-by: Ac_K <Acoustik666@gmail.com>

* First dotnet format pass

* Fix naming rule violations

* Remove naming rule violation exceptions

* Fix comment style

* Use targeted new

* Remove redundant code

* Remove comment alignment

* Remove naming rule exceptions

* Add trailing commas

* Use nameof expression

* Reformat to add remaining trailing commas

---------

Co-authored-by: Ac_K <Acoustik666@gmail.com>

distribution/macos/create_macos_build.sh

@@ -35,12 +35,12 @@ EXECUTABLE_SUB_PATH=Contents/MacOS/Ryujinx
 rm -rf "$TEMP_DIRECTORY"
 mkdir -p "$TEMP_DIRECTORY"
 
-DOTNET_COMMON_ARGS="-p:DebugType=embedded -p:Version=$VERSION -p:SourceRevisionId=$SOURCE_REVISION_ID --self-contained true $EXTRA_ARGS"
+DOTNET_COMMON_ARGS=(-p:DebugType=embedded -p:Version="$VERSION" -p:SourceRevisionId="$SOURCE_REVISION_ID" --self-contained true $EXTRA_ARGS)
 
 dotnet restore
-dotnet build -c $CONFIGURATION src/Ryujinx.Ava
+dotnet build -c "$CONFIGURATION" src/Ryujinx.Ava
-dotnet publish -c $CONFIGURATION -r osx-arm64 -o "$TEMP_DIRECTORY/publish_arm64" $DOTNET_COMMON_ARGS src/Ryujinx.Ava
+dotnet publish -c "$CONFIGURATION" -r osx-arm64 -o "$TEMP_DIRECTORY/publish_arm64" "${DOTNET_COMMON_ARGS[@]}" src/Ryujinx.Ava
-dotnet publish -c $CONFIGURATION -r osx-x64 -o "$TEMP_DIRECTORY/publish_x64" $DOTNET_COMMON_ARGS src/Ryujinx.Ava
+dotnet publish -c "$CONFIGURATION" -r osx-x64 -o "$TEMP_DIRECTORY/publish_x64" "${DOTNET_COMMON_ARGS[@]}" src/Ryujinx.Ava
 
 # Get rid of the support library for ARMeilleure for x64 (that's only for arm64)
 rm -rf "$TEMP_DIRECTORY/publish_x64/libarmeilleure-jitsupport.dylib"
@@ -104,10 +104,10 @@ fi
 
 echo "Creating archive"
 pushd "$OUTPUT_DIRECTORY"
-tar --exclude "Ryujinx.app/Contents/MacOS/Ryujinx" -cvf $RELEASE_TAR_FILE_NAME Ryujinx.app 1> /dev/null
+tar --exclude "Ryujinx.app/Contents/MacOS/Ryujinx" -cvf "$RELEASE_TAR_FILE_NAME" Ryujinx.app 1> /dev/null
-python3 "$BASE_DIR/distribution/misc/add_tar_exec.py" $RELEASE_TAR_FILE_NAME "Ryujinx.app/Contents/MacOS/Ryujinx" "Ryujinx.app/Contents/MacOS/Ryujinx"
+python3 "$BASE_DIR/distribution/misc/add_tar_exec.py" "$RELEASE_TAR_FILE_NAME" "Ryujinx.app/Contents/MacOS/Ryujinx" "Ryujinx.app/Contents/MacOS/Ryujinx"
-gzip -9 < $RELEASE_TAR_FILE_NAME > $RELEASE_TAR_FILE_NAME.gz
+gzip -9 < "$RELEASE_TAR_FILE_NAME" > "$RELEASE_TAR_FILE_NAME.gz"
-rm $RELEASE_TAR_FILE_NAME
+rm "$RELEASE_TAR_FILE_NAME"
 popd
 
 echo "Done"

distribution/macos/updater.sh

@@ -5,7 +5,7 @@ set -e
 INSTALL_DIRECTORY=$1
 NEW_APP_DIRECTORY=$2
 APP_PID=$3
-APP_ARGUMENTS="${@:4}"
+APP_ARGUMENTS=("${@:4}")
 
 error_handler() {
     local lineno="$1"
@@ -33,7 +33,7 @@ trap 'error_handler ${LINENO}' ERR
 
 attempt=0
 while true; do
-    if lsof -p $APP_PID +r 1 &>/dev/null || ps -p "$APP_PID" &>/dev/null; then
+    if lsof -p "$APP_PID" +r 1 &>/dev/null || ps -p "$APP_PID" &>/dev/null; then
         if [ "$attempt" -eq 4 ]; then
             exit 1
         fi
@@ -53,5 +53,5 @@ mv "$NEW_APP_DIRECTORY" "$INSTALL_DIRECTORY"
 if [ "$#" -le 3 ]; then
     open -a "$INSTALL_DIRECTORY"
 else
-    open -a "$INSTALL_DIRECTORY" --args "$APP_ARGUMENTS"
+    open -a "$INSTALL_DIRECTORY" --args "${APP_ARGUMENTS[@]}"
-fi
+fi

src/Ryujinx.Ava/AppHost.cs

@@ -32,6 +32,7 @@ using Ryujinx.HLE.HOS.Services.Account.Acc;
 using Ryujinx.HLE.HOS.SystemState;
 using Ryujinx.Input;
 using Ryujinx.Input.HLE;
+using Ryujinx.Ui.App.Common;
 using Ryujinx.Ui.Common;
 using Ryujinx.Ui.Common.Configuration;
 using Ryujinx.Ui.Common.Helper;
@@ -692,7 +693,7 @@ namespace Ryujinx.Ava
 
             DiscordIntegrationModule.SwitchToPlayingState(Device.Processes.ActiveApplication.ProgramIdText, Device.Processes.ActiveApplication.Name);
 
-            _viewModel.ApplicationLibrary.LoadAndSaveMetaData(Device.Processes.ActiveApplication.ProgramIdText, appMetadata =>
+            ApplicationLibrary.LoadAndSaveMetaData(Device.Processes.ActiveApplication.ProgramIdText, appMetadata =>
             {
                 appMetadata.LastPlayed = DateTime.UtcNow;
             });

src/Ryujinx.Ava/UI/Controls/ApplicationContextMenu.axaml.cs

@@ -42,7 +42,7 @@ namespace Ryujinx.Ava.UI.Controls
             {
                 viewModel.SelectedApplication.Favorite = !viewModel.SelectedApplication.Favorite;
 
-                viewModel.ApplicationLibrary.LoadAndSaveMetaData(viewModel.SelectedApplication.TitleId, appMetadata =>
+                ApplicationLibrary.LoadAndSaveMetaData(viewModel.SelectedApplication.TitleId, appMetadata =>
                 {
                     appMetadata.Favorite = viewModel.SelectedApplication.Favorite;
                 });

src/Ryujinx.Ava/UI/Models/SaveModel.cs

@@ -3,6 +3,7 @@ using LibHac.Ncm;
 using Ryujinx.Ava.UI.ViewModels;
 using Ryujinx.Ava.UI.Windows;
 using Ryujinx.HLE.FileSystem;
+using Ryujinx.Ui.App.Common;
 using System;
 using System.IO;
 using System.Linq;
@@ -74,7 +75,7 @@ namespace Ryujinx.Ava.UI.Models
             }
             else
             {
-                var appMetadata = MainWindow.MainWindowViewModel.ApplicationLibrary.LoadAndSaveMetaData(TitleIdString);
+                var appMetadata = ApplicationLibrary.LoadAndSaveMetaData(TitleIdString);
                 Title = appMetadata.Title ?? TitleIdString;
             }
 

src/Ryujinx.Ava/UI/Renderer/EmbeddedWindow.cs

@@ -239,28 +239,28 @@ namespace Ryujinx.Ava.UI.Renderer
         IPlatformHandle CreateMacOS()
         {
             // Create a new CAMetalLayer.
-            IntPtr layerClass = ObjectiveC.objc_getClass("CAMetalLayer");
+            ObjectiveC.Object layerObject = new("CAMetalLayer");
-            IntPtr metalLayer = ObjectiveC.IntPtr_objc_msgSend(layerClass, "alloc");
+            ObjectiveC.Object metalLayer = layerObject.GetFromMessage("alloc");
-            ObjectiveC.objc_msgSend(metalLayer, "init");
+            metalLayer.SendMessage("init");
 
             // Create a child NSView to render into.
-            IntPtr nsViewClass = ObjectiveC.objc_getClass("NSView");
+            ObjectiveC.Object nsViewObject = new("NSView");
-            IntPtr child = ObjectiveC.IntPtr_objc_msgSend(nsViewClass, "alloc");
+            ObjectiveC.Object child = nsViewObject.GetFromMessage("alloc");
-            ObjectiveC.objc_msgSend(child, "init", new ObjectiveC.NSRect(0, 0, 0, 0));
+            child.SendMessage("init", new ObjectiveC.NSRect(0, 0, 0, 0));
 
             // Make its renderer our metal layer.
-            ObjectiveC.objc_msgSend(child, "setWantsLayer:", 1);
+            child.SendMessage("setWantsLayer:", 1);
-            ObjectiveC.objc_msgSend(child, "setLayer:", metalLayer);
+            child.SendMessage("setLayer:", metalLayer);
-            ObjectiveC.objc_msgSend(metalLayer, "setContentsScale:", Program.DesktopScaleFactor);
+            metalLayer.SendMessage("setContentsScale:", Program.DesktopScaleFactor);
 
             // Ensure the scale factor is up to date.
             _updateBoundsCallback = rect =>
             {
-                ObjectiveC.objc_msgSend(metalLayer, "setContentsScale:", Program.DesktopScaleFactor);
+                metalLayer.SendMessage("setContentsScale:", Program.DesktopScaleFactor);
             };
 
-            IntPtr nsView = child;
+            IntPtr nsView = child.ObjPtr;
-            MetalLayer = metalLayer;
+            MetalLayer = metalLayer.ObjPtr;
             NsView = nsView;
 
             return new PlatformHandle(nsView, "NSView");

src/Ryujinx.Graphics.GAL/AddressMode.cs

@@ -9,6 +9,6 @@ namespace Ryujinx.Graphics.GAL
         Clamp,
         MirrorClampToEdge,
         MirrorClampToBorder,
-        MirrorClamp
+        MirrorClamp,
     }
-}
+}

src/Ryujinx.Graphics.GAL/AdvancedBlendDescriptor.cs

@@ -1,6 +1,6 @@
 namespace Ryujinx.Graphics.GAL
 {
-    public struct AdvancedBlendDescriptor
+    public readonly struct AdvancedBlendDescriptor
     {
         public AdvancedBlendOp Op { get; }
         public AdvancedBlendOverlap Overlap { get; }

src/Ryujinx.Graphics.GAL/AdvancedBlendOp.cs

@@ -47,6 +47,6 @@ namespace Ryujinx.Graphics.GAL
         HslHue,
         HslSaturation,
         HslColor,
-        HslLuminosity
+        HslLuminosity,
     }
-}
+}

src/Ryujinx.Graphics.GAL/AdvancedBlendOverlap.cs

@@ -4,6 +4,6 @@ namespace Ryujinx.Graphics.GAL
     {
         Uncorrelated,
         Disjoint,
-        Conjoint
+        Conjoint,
     }
 }

src/Ryujinx.Graphics.GAL/AntiAliasing.cs

@@ -7,6 +7,6 @@
         SmaaLow,
         SmaaMedium,
         SmaaHigh,
-        SmaaUltra
+        SmaaUltra,
     }
 }

src/Ryujinx.Graphics.GAL/BlendDescriptor.cs

@@ -4,30 +4,30 @@ namespace Ryujinx.Graphics.GAL
     {
         public bool Enable { get; }
 
-        public ColorF      BlendConstant  { get; }
+        public ColorF BlendConstant { get; }
-        public BlendOp     ColorOp        { get; }
+        public BlendOp ColorOp { get; }
         public BlendFactor ColorSrcFactor { get; }
         public BlendFactor ColorDstFactor { get; }
-        public BlendOp     AlphaOp        { get; }
+        public BlendOp AlphaOp { get; }
         public BlendFactor AlphaSrcFactor { get; }
         public BlendFactor AlphaDstFactor { get; }
 
         public BlendDescriptor(
-            bool        enable,
+            bool enable,
-            ColorF      blendConstant,
+            ColorF blendConstant,
-            BlendOp     colorOp,
+            BlendOp colorOp,
             BlendFactor colorSrcFactor,
             BlendFactor colorDstFactor,
-            BlendOp     alphaOp,
+            BlendOp alphaOp,
             BlendFactor alphaSrcFactor,
             BlendFactor alphaDstFactor)
         {
-            Enable         = enable;
+            Enable = enable;
-            BlendConstant  = blendConstant;
+            BlendConstant = blendConstant;
-            ColorOp        = colorOp;
+            ColorOp = colorOp;
             ColorSrcFactor = colorSrcFactor;
             ColorDstFactor = colorDstFactor;
-            AlphaOp        = alphaOp;
+            AlphaOp = alphaOp;
             AlphaSrcFactor = alphaSrcFactor;
             AlphaDstFactor = alphaDstFactor;
         }

src/Ryujinx.Graphics.GAL/BlendFactor.cs

@@ -22,21 +22,21 @@ namespace Ryujinx.Graphics.GAL
         ConstantAlpha,
         OneMinusConstantAlpha,
 
-        ZeroGl                  = 0x4000,
+        ZeroGl = 0x4000,
-        OneGl                   = 0x4001,
+        OneGl = 0x4001,
-        SrcColorGl              = 0x4300,
+        SrcColorGl = 0x4300,
-        OneMinusSrcColorGl      = 0x4301,
+        OneMinusSrcColorGl = 0x4301,
-        SrcAlphaGl              = 0x4302,
+        SrcAlphaGl = 0x4302,
-        OneMinusSrcAlphaGl      = 0x4303,
+        OneMinusSrcAlphaGl = 0x4303,
-        DstAlphaGl              = 0x4304,
+        DstAlphaGl = 0x4304,
-        OneMinusDstAlphaGl      = 0x4305,
+        OneMinusDstAlphaGl = 0x4305,
-        DstColorGl              = 0x4306,
+        DstColorGl = 0x4306,
-        OneMinusDstColorGl      = 0x4307,
+        OneMinusDstColorGl = 0x4307,
-        SrcAlphaSaturateGl      = 0x4308,
+        SrcAlphaSaturateGl = 0x4308,
-        Src1ColorGl             = 0xc900,
+        Src1ColorGl = 0xc900,
-        OneMinusSrc1ColorGl     = 0xc901,
+        OneMinusSrc1ColorGl = 0xc901,
-        Src1AlphaGl             = 0xc902,
+        Src1AlphaGl = 0xc902,
-        OneMinusSrc1AlphaGl     = 0xc903
+        OneMinusSrc1AlphaGl = 0xc903,
     }
 
     public static class BlendFactorExtensions
@@ -54,9 +54,9 @@ namespace Ryujinx.Graphics.GAL
                 case BlendFactor.OneMinusSrc1Alpha:
                 case BlendFactor.OneMinusSrc1AlphaGl:
                     return true;
+                default:
+                    return false;
             }
-
-            return false;
         }
     }
-}
+}

src/Ryujinx.Graphics.GAL/BlendOp.cs

@@ -8,10 +8,10 @@ namespace Ryujinx.Graphics.GAL
         Minimum,
         Maximum,
 
-        AddGl             = 0x8006,
+        AddGl = 0x8006,
-        MinimumGl         = 0x8007,
+        MinimumGl = 0x8007,
-        MaximumGl         = 0x8008,
+        MaximumGl = 0x8008,
-        SubtractGl        = 0x800a,
+        SubtractGl = 0x800a,
-        ReverseSubtractGl = 0x800b
+        ReverseSubtractGl = 0x800b,
     }
 }

src/Ryujinx.Graphics.GAL/BufferAccess.cs

@@ -3,6 +3,6 @@ namespace Ryujinx.Graphics.GAL
     public enum BufferAccess
     {
         Default,
-        FlushPersistent
+        FlushPersistent,
     }
 }

src/Ryujinx.Graphics.GAL/BufferAssignment.cs

@@ -11,4 +11,4 @@
             Range = range;
         }
     }
-}
+}

src/Ryujinx.Graphics.GAL/BufferHandle.cs

@@ -7,7 +7,7 @@ namespace Ryujinx.Graphics.GAL
     {
         private readonly ulong _value;
 
-        public static BufferHandle Null => new BufferHandle(0);
+        public static BufferHandle Null => new(0);
 
         private BufferHandle(ulong value) => _value = value;
     }

src/Ryujinx.Graphics.GAL/BufferRange.cs

@@ -2,20 +2,20 @@ namespace Ryujinx.Graphics.GAL
 {
     public readonly struct BufferRange
     {
-        private static readonly BufferRange _empty = new BufferRange(BufferHandle.Null, 0, 0);
+        private static readonly BufferRange _empty = new(BufferHandle.Null, 0, 0);
 
         public static BufferRange Empty => _empty;
 
         public BufferHandle Handle { get; }
 
         public int Offset { get; }
-        public int Size   { get; }
+        public int Size { get; }
 
         public BufferRange(BufferHandle handle, int offset, int size)
         {
             Handle = handle;
             Offset = offset;
-            Size   = size;
+            Size = size;
         }
     }
-}
+}

src/Ryujinx.Graphics.GAL/Capabilities.cs

@@ -149,4 +149,4 @@ namespace Ryujinx.Graphics.GAL
             GatherBiasPrecision = gatherBiasPrecision;
         }
     }
-}
+}

src/Ryujinx.Graphics.GAL/CompareMode.cs

@@ -3,6 +3,6 @@ namespace Ryujinx.Graphics.GAL
     public enum CompareMode
     {
         None,
-        CompareRToTexture
+        CompareRToTexture,
     }
-}
+}

src/Ryujinx.Graphics.GAL/CompareOp.cs

@@ -11,13 +11,13 @@ namespace Ryujinx.Graphics.GAL
         GreaterOrEqual,
         Always,
 
-        NeverGl          = 0x200,
+        NeverGl = 0x200,
-        LessGl           = 0x201,
+        LessGl = 0x201,
-        EqualGl          = 0x202,
+        EqualGl = 0x202,
-        LessOrEqualGl    = 0x203,
+        LessOrEqualGl = 0x203,
-        GreaterGl        = 0x204,
+        GreaterGl = 0x204,
-        NotEqualGl       = 0x205,
+        NotEqualGl = 0x205,
         GreaterOrEqualGl = 0x206,
-        AlwaysGl         = 0x207,
+        AlwaysGl = 0x207,
     }
-}
+}

src/Ryujinx.Graphics.GAL/CounterType.cs

@@ -4,6 +4,6 @@ namespace Ryujinx.Graphics.GAL
     {
         SamplesPassed,
         PrimitivesGenerated,
-        TransformFeedbackPrimitivesWritten
+        TransformFeedbackPrimitivesWritten,
     }
-}
+}

src/Ryujinx.Graphics.GAL/DepthMode.cs

@@ -3,6 +3,6 @@ namespace Ryujinx.Graphics.GAL
     public enum DepthMode
     {
         MinusOneToOne,
-        ZeroToOne
+        ZeroToOne,
     }
-}
+}

src/Ryujinx.Graphics.GAL/DepthStencilMode.cs

@@ -3,6 +3,6 @@ namespace Ryujinx.Graphics.GAL
     public enum DepthStencilMode
     {
         Depth,
-        Stencil
+        Stencil,
     }
-}
+}

src/Ryujinx.Graphics.GAL/DepthTestDescriptor.cs

@@ -2,19 +2,19 @@ namespace Ryujinx.Graphics.GAL
 {
     public readonly struct DepthTestDescriptor
     {
-        public bool TestEnable  { get; }
+        public bool TestEnable { get; }
         public bool WriteEnable { get; }
 
         public CompareOp Func { get; }
 
         public DepthTestDescriptor(
-            bool      testEnable,
+            bool testEnable,
-            bool      writeEnable,
+            bool writeEnable,
             CompareOp func)
         {
-            TestEnable  = testEnable;
+            TestEnable = testEnable;
             WriteEnable = writeEnable;
-            Func        = func;
+            Func = func;
         }
     }
 }

src/Ryujinx.Graphics.GAL/DeviceInfo.cs

@@ -15,4 +15,4 @@ namespace Ryujinx.Graphics.GAL
             IsDiscrete = isDiscrete;
         }
     }
-}
+}

src/Ryujinx.Graphics.GAL/Extents2D.cs

@@ -20,12 +20,12 @@ namespace Ryujinx.Graphics.GAL
         public Extents2D Reduce(int level)
         {
             int div = 1 << level;
-            
+
             return new Extents2D(
-                X1 >> level, 
+                X1 >> level,
                 Y1 >> level,
                 BitUtils.DivRoundUp(X2, div),
                 BitUtils.DivRoundUp(Y2, div));
         }
     }
-}
+}

src/Ryujinx.Graphics.GAL/Extents2DF.cs

@@ -15,4 +15,4 @@ namespace Ryujinx.Graphics.GAL
             Y2 = y2;
         }
     }
-}
+}

src/Ryujinx.Graphics.GAL/Face.cs

@@ -2,8 +2,8 @@ namespace Ryujinx.Graphics.GAL
 {
     public enum Face
     {
-        Front        = 0x404,
+        Front = 0x404,
-        Back         = 0x405,
+        Back = 0x405,
-        FrontAndBack = 0x408
+        FrontAndBack = 0x408,
     }
-}
+}

src/Ryujinx.Graphics.GAL/Format.cs

@@ -146,7 +146,7 @@ namespace Ryujinx.Graphics.GAL
         B5G5R5A1Unorm,
         A1B5G5R5Unorm,
         B8G8R8A8Unorm,
-        B8G8R8A8Srgb
+        B8G8R8A8Srgb,
     }
 
     public static class FormatExtensions
@@ -665,4 +665,4 @@ namespace Ryujinx.Graphics.GAL
             return format.IsUint() || format.IsSint();
         }
     }
-}
+}

src/Ryujinx.Graphics.GAL/FrontFace.cs

@@ -2,7 +2,7 @@ namespace Ryujinx.Graphics.GAL
 {
     public enum FrontFace
     {
-        Clockwise        = 0x900,
+        Clockwise = 0x900,
-        CounterClockwise = 0x901
+        CounterClockwise = 0x901,
     }
-}
+}

src/Ryujinx.Graphics.GAL/ISampler.cs

@@ -3,4 +3,4 @@ using System;
 namespace Ryujinx.Graphics.GAL
 {
     public interface ISampler : IDisposable { }
-}
+}

src/Ryujinx.Graphics.GAL/ITexture.cs

@@ -1,5 +1,4 @@
 using Ryujinx.Common.Memory;
-using System;
 
 namespace Ryujinx.Graphics.GAL
 {
@@ -25,4 +24,4 @@ namespace Ryujinx.Graphics.GAL
         void SetStorage(BufferRange buffer);
         void Release();
     }
-}
+}

src/Ryujinx.Graphics.GAL/ImageCrop.cs

@@ -2,36 +2,36 @@ namespace Ryujinx.Graphics.GAL
 {
     public readonly struct ImageCrop
     {
-        public int   Left         { get; }
+        public int Left { get; }
-        public int   Right        { get; }
+        public int Right { get; }
-        public int   Top          { get; }
+        public int Top { get; }
-        public int   Bottom       { get; }
+        public int Bottom { get; }
-        public bool  FlipX        { get; }
+        public bool FlipX { get; }
-        public bool  FlipY        { get; }
+        public bool FlipY { get; }
-        public bool  IsStretched  { get; }
+        public bool IsStretched { get; }
         public float AspectRatioX { get; }
         public float AspectRatioY { get; }
 
         public ImageCrop(
-            int   left,
+            int left,
-            int   right,
+            int right,
-            int   top,
+            int top,
-            int   bottom,
+            int bottom,
-            bool  flipX,
+            bool flipX,
-            bool  flipY,
+            bool flipY,
-            bool  isStretched,
+            bool isStretched,
             float aspectRatioX,
             float aspectRatioY)
         {
-            Left         = left;
+            Left = left;
-            Right        = right;
+            Right = right;
-            Top          = top;
+            Top = top;
-            Bottom       = bottom;
+            Bottom = bottom;
-            FlipX        = flipX;
+            FlipX = flipX;
-            FlipY        = flipY;
+            FlipY = flipY;
-            IsStretched  = isStretched;
+            IsStretched = isStretched;
             AspectRatioX = aspectRatioX;
             AspectRatioY = aspectRatioY;
         }
     }
-}
+}

src/Ryujinx.Graphics.GAL/IndexType.cs

@@ -4,6 +4,6 @@ namespace Ryujinx.Graphics.GAL
     {
         UByte,
         UShort,
-        UInt
+        UInt,
     }
-}
+}

src/Ryujinx.Graphics.GAL/LogicalOp.cs

@@ -17,6 +17,6 @@
         CopyInverted = 0x150C,
         OrInverted = 0x150D,
         Nand = 0x150E,
-        Set = 0x150F
+        Set = 0x150F,
     }
 }

src/Ryujinx.Graphics.GAL/MagFilter.cs

@@ -3,6 +3,6 @@ namespace Ryujinx.Graphics.GAL
     public enum MagFilter
     {
         Nearest = 1,
-        Linear
+        Linear,
     }
-}
+}

src/Ryujinx.Graphics.GAL/MinFilter.cs

@@ -7,6 +7,6 @@ namespace Ryujinx.Graphics.GAL
         NearestMipmapNearest,
         LinearMipmapNearest,
         NearestMipmapLinear,
-        LinearMipmapLinear
+        LinearMipmapLinear,
     }
-}
+}

src/Ryujinx.Graphics.GAL/Multithreading/BufferMap.cs

@@ -15,9 +15,9 @@ namespace Ryujinx.Graphics.GAL.Multithreading
     {
         private ulong _bufferHandle = 0;
 
-        private Dictionary<BufferHandle, BufferHandle> _bufferMap = new Dictionary<BufferHandle, BufferHandle>();
+        private readonly Dictionary<BufferHandle, BufferHandle> _bufferMap = new();
-        private HashSet<BufferHandle> _inFlight = new HashSet<BufferHandle>();
+        private readonly HashSet<BufferHandle> _inFlight = new();
-        private AutoResetEvent _inFlightChanged = new AutoResetEvent(false);
+        private readonly AutoResetEvent _inFlightChanged = new(false);
 
         internal BufferHandle CreateBufferHandle()
         {
@@ -59,14 +59,12 @@ namespace Ryujinx.Graphics.GAL.Multithreading
         internal BufferHandle MapBuffer(BufferHandle handle)
         {
             // Maps a threaded buffer to a backend one.
-            // Threaded buffers are returned on creation as the buffer 
+            // Threaded buffers are returned on creation as the buffer
             // isn't actually created until the queue runs the command.
 
-            BufferHandle result;
-
             lock (_bufferMap)
             {
-                if (!_bufferMap.TryGetValue(handle, out result))
+                if (!_bufferMap.TryGetValue(handle, out BufferHandle result))
                 {
                     result = BufferHandle.Null;
                 }
@@ -79,11 +77,10 @@ namespace Ryujinx.Graphics.GAL.Multithreading
         {
             // Blocks until the handle is available.
 
-            BufferHandle result;
 
             lock (_bufferMap)
             {
-                if (_bufferMap.TryGetValue(handle, out result))
+                if (_bufferMap.TryGetValue(handle, out BufferHandle result))
                 {
                     return result;
                 }
@@ -128,9 +125,8 @@ namespace Ryujinx.Graphics.GAL.Multithreading
                 for (int i = 0; i < ranges.Length; i++)
                 {
                     ref BufferRange range = ref ranges[i];
-                    BufferHandle result;
 
-                    if (!_bufferMap.TryGetValue(range.Handle, out result))
+                    if (!_bufferMap.TryGetValue(range.Handle, out BufferHandle result))
                     {
                         result = BufferHandle.Null;
                     }
@@ -152,9 +148,8 @@ namespace Ryujinx.Graphics.GAL.Multithreading
                 {
                     ref BufferAssignment assignment = ref ranges[i];
                     BufferRange range = assignment.Range;
-                    BufferHandle result;
 
-                    if (!_bufferMap.TryGetValue(range.Handle, out result))
+                    if (!_bufferMap.TryGetValue(range.Handle, out BufferHandle result))
                     {
                         result = BufferHandle.Null;
                     }
@@ -175,9 +170,8 @@ namespace Ryujinx.Graphics.GAL.Multithreading
                 for (int i = 0; i < ranges.Length; i++)
                 {
                     BufferRange range = ranges[i].Buffer;
-                    BufferHandle result;
 
-                    if (!_bufferMap.TryGetValue(range.Handle, out result))
+                    if (!_bufferMap.TryGetValue(range.Handle, out BufferHandle result))
                     {
                         result = BufferHandle.Null;
                     }

src/Ryujinx.Graphics.GAL/Multithreading/CommandHelper.cs

@@ -17,8 +17,8 @@ namespace Ryujinx.Graphics.GAL.Multithreading
     {
         private delegate void CommandDelegate(Span<byte> memory, ThreadedRenderer threaded, IRenderer renderer);
 
-        private static int _totalCommands = (int)Enum.GetValues<CommandType>().Max() + 1;
+        private static readonly int _totalCommands = (int)Enum.GetValues<CommandType>().Max() + 1;
-        private static CommandDelegate[] _lookup = new CommandDelegate[_totalCommands];
+        private static readonly CommandDelegate[] _lookup = new CommandDelegate[_totalCommands];
 
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         private static ref T GetCommand<T>(Span<byte> memory)
@@ -146,7 +146,7 @@ namespace Ryujinx.Graphics.GAL.Multithreading
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public static void RunCommand(Span<byte> memory, ThreadedRenderer threaded, IRenderer renderer)
         {
-            _lookup[memory[memory.Length - 1]](memory, threaded, renderer);
+            _lookup[memory[^1]](memory, threaded, renderer);
         }
     }
 }

src/Ryujinx.Graphics.GAL/Multithreading/CommandType.cs

@@ -100,6 +100,6 @@
         TextureBarrierTiled,
         TryHostConditionalRendering,
         TryHostConditionalRenderingFlush,
-        UpdateRenderScale
+        UpdateRenderScale,
     }
 }

src/Ryujinx.Graphics.GAL/Multithreading/Commands/BarrierCommand.cs

@@ -2,7 +2,7 @@
 {
     struct BarrierCommand : IGALCommand, IGALCommand<BarrierCommand>
     {
-        public CommandType CommandType => CommandType.Barrier;
+        public readonly CommandType CommandType => CommandType.Barrier;
 
         public static void Run(ref BarrierCommand command, ThreadedRenderer threaded, IRenderer renderer)
         {

src/Ryujinx.Graphics.GAL/Multithreading/Commands/BeginTransformFeedbackCommand.cs

@@ -2,7 +2,7 @@
 {
     struct BeginTransformFeedbackCommand : IGALCommand, IGALCommand<BeginTransformFeedbackCommand>
     {
-        public CommandType CommandType => CommandType.BeginTransformFeedback;
+        public readonly CommandType CommandType => CommandType.BeginTransformFeedback;
         private PrimitiveTopology _topology;
 
         public void Set(PrimitiveTopology topology)

src/Ryujinx.Graphics.GAL/Multithreading/Commands/Buffer/BufferDisposeCommand.cs

@@ -2,7 +2,7 @@
 {
     struct BufferDisposeCommand : IGALCommand, IGALCommand<BufferDisposeCommand>
     {
-        public CommandType CommandType => CommandType.BufferDispose;
+        public readonly CommandType CommandType => CommandType.BufferDispose;
         private BufferHandle _buffer;
 
         public void Set(BufferHandle buffer)

src/Ryujinx.Graphics.GAL/Multithreading/Commands/Buffer/BufferGetDataCommand.cs

@@ -1,11 +1,10 @@
 using Ryujinx.Graphics.GAL.Multithreading.Model;
-using System;
 
 namespace Ryujinx.Graphics.GAL.Multithreading.Commands.Buffer
 {
     struct BufferGetDataCommand : IGALCommand, IGALCommand<BufferGetDataCommand>
     {
-        public CommandType CommandType => CommandType.BufferGetData;
+        public readonly CommandType CommandType => CommandType.BufferGetData;
         private BufferHandle _buffer;
         private int _offset;
         private int _size;

src/Ryujinx.Graphics.GAL/Multithreading/Commands/Buffer/BufferSetDataCommand.cs

@@ -5,7 +5,7 @@ namespace Ryujinx.Graphics.GAL.Multithreading.Commands.Buffer
 {
     struct BufferSetDataCommand : IGALCommand, IGALCommand<BufferSetDataCommand>
     {
-        public CommandType CommandType => CommandType.BufferSetData;
+        public readonly CommandType CommandType => CommandType.BufferSetData;
         private BufferHandle _buffer;
         private int _offset;
         private SpanRef<byte> _data;

src/Ryujinx.Graphics.GAL/Multithreading/Commands/ClearBufferCommand.cs

@@ -2,7 +2,7 @@
 {
     struct ClearBufferCommand : IGALCommand, IGALCommand<ClearBufferCommand>
     {
-        public CommandType CommandType => CommandType.ClearBuffer;
+        public readonly CommandType CommandType => CommandType.ClearBuffer;
         private BufferHandle _destination;
         private int _offset;
         private int _size;

src/Ryujinx.Graphics.GAL/Multithreading/Commands/ClearRenderTargetColorCommand.cs

@@ -2,7 +2,7 @@
 {
     struct ClearRenderTargetColorCommand : IGALCommand, IGALCommand<ClearRenderTargetColorCommand>
     {
-        public CommandType CommandType => CommandType.ClearRenderTargetColor;
+        public readonly CommandType CommandType => CommandType.ClearRenderTargetColor;
         private int _index;
         private int _layer;
         private int _layerCount;

src/Ryujinx.Graphics.GAL/Multithreading/Commands/ClearRenderTargetDepthStencilCommand.cs

@@ -2,7 +2,7 @@
 {
     struct ClearRenderTargetDepthStencilCommand : IGALCommand, IGALCommand<ClearRenderTargetDepthStencilCommand>
     {
-        public CommandType CommandType => CommandType.ClearRenderTargetDepthStencil;
+        public readonly CommandType CommandType => CommandType.ClearRenderTargetDepthStencil;
         private int _layer;
         private int _layerCount;
         private float _depthValue;

src/Ryujinx.Graphics.GAL/Multithreading/Commands/CommandBufferBarrierCommand.cs

@@ -2,7 +2,7 @@
 {
     struct CommandBufferBarrierCommand : IGALCommand, IGALCommand<CommandBufferBarrierCommand>
     {
-        public CommandType CommandType => CommandType.CommandBufferBarrier;
+        public readonly CommandType CommandType => CommandType.CommandBufferBarrier;
 
         public static void Run(ref CommandBufferBarrierCommand command, ThreadedRenderer threaded, IRenderer renderer)
         {

src/Ryujinx.Graphics.GAL/Multithreading/Commands/CopyBufferCommand.cs

@@ -2,7 +2,7 @@
 {
     struct CopyBufferCommand : IGALCommand, IGALCommand<CopyBufferCommand>
     {
-        public CommandType CommandType => CommandType.CopyBuffer;
+        public readonly CommandType CommandType => CommandType.CopyBuffer;
         private BufferHandle _source;
         private BufferHandle _destination;
         private int _srcOffset;

src/Ryujinx.Graphics.GAL/Multithreading/Commands/CounterEvent/CounterEventDisposeCommand.cs

@@ -5,7 +5,7 @@ namespace Ryujinx.Graphics.GAL.Multithreading.Commands.CounterEvent
 {
     struct CounterEventDisposeCommand : IGALCommand, IGALCommand<CounterEventDisposeCommand>
     {
-        public CommandType CommandType => CommandType.CounterEventDispose;
+        public readonly CommandType CommandType => CommandType.CounterEventDispose;
         private TableRef<ThreadedCounterEvent> _event;
 
         public void Set(TableRef<ThreadedCounterEvent> evt)

src/Ryujinx.Graphics.GAL/Multithreading/Commands/CounterEvent/CounterEventFlushCommand.cs

@@ -5,7 +5,7 @@ namespace Ryujinx.Graphics.GAL.Multithreading.Commands.CounterEvent
 {
     struct CounterEventFlushCommand : IGALCommand, IGALCommand<CounterEventFlushCommand>
     {
-        public CommandType CommandType => CommandType.CounterEventFlush;
+        public readonly CommandType CommandType => CommandType.CounterEventFlush;
         private TableRef<ThreadedCounterEvent> _event;
 
         public void Set(TableRef<ThreadedCounterEvent> evt)

src/Ryujinx.Graphics.GAL/Multithreading/Commands/DispatchComputeCommand.cs

@@ -2,7 +2,7 @@
 {
     struct DispatchComputeCommand : IGALCommand, IGALCommand<DispatchComputeCommand>
     {
-        public CommandType CommandType => CommandType.DispatchCompute;
+        public readonly CommandType CommandType => CommandType.DispatchCompute;
         private int _groupsX;
         private int _groupsY;
         private int _groupsZ;

src/Ryujinx.Graphics.GAL/Multithreading/Commands/DrawCommand.cs

@@ -2,7 +2,7 @@
 {
     struct DrawIndexedCommand : IGALCommand, IGALCommand<DrawIndexedCommand>
     {
-        public CommandType CommandType => CommandType.DrawIndexed;
+        public readonly CommandType CommandType => CommandType.DrawIndexed;
         private int _indexCount;
         private int _instanceCount;
         private int _firstIndex;

src/Ryujinx.Graphics.GAL/Multithreading/Commands/DrawIndexedCommand.cs

@@ -2,7 +2,7 @@
 {
     struct DrawCommand : IGALCommand, IGALCommand<DrawCommand>
     {
-        public CommandType CommandType => CommandType.Draw;
+        public readonly CommandType CommandType => CommandType.Draw;
         private int _vertexCount;
         private int _instanceCount;
         private int _firstVertex;

src/Ryujinx.Graphics.GAL/Multithreading/Commands/DrawIndexedIndirectCommand.cs

@@ -2,7 +2,7 @@ namespace Ryujinx.Graphics.GAL.Multithreading.Commands
 {
     struct DrawIndexedIndirectCommand : IGALCommand, IGALCommand<DrawIndexedIndirectCommand>
     {
-        public CommandType CommandType => CommandType.DrawIndexedIndirect;
+        public readonly CommandType CommandType => CommandType.DrawIndexedIndirect;
         private BufferRange _indirectBuffer;
 
         public void Set(BufferRange indirectBuffer)

src/Ryujinx.Graphics.GAL/Multithreading/Commands/DrawIndexedIndirectCountCommand.cs

@@ -2,7 +2,7 @@
 {
     struct DrawIndexedIndirectCountCommand : IGALCommand, IGALCommand<DrawIndexedIndirectCountCommand>
     {
-        public CommandType CommandType => CommandType.DrawIndexedIndirectCount;
+        public readonly CommandType CommandType => CommandType.DrawIndexedIndirectCount;
         private BufferRange _indirectBuffer;
         private BufferRange _parameterBuffer;
         private int _maxDrawCount;

src/Ryujinx.Graphics.GAL/Multithreading/Commands/DrawIndirectCommand.cs

@@ -2,7 +2,7 @@ namespace Ryujinx.Graphics.GAL.Multithreading.Commands
 {
     struct DrawIndirectCommand : IGALCommand, IGALCommand<DrawIndirectCommand>
     {
-        public CommandType CommandType => CommandType.DrawIndirect;
+        public readonly CommandType CommandType => CommandType.DrawIndirect;
         private BufferRange _indirectBuffer;
 
         public void Set(BufferRange indirectBuffer)

src/Ryujinx.Graphics.GAL/Multithreading/Commands/DrawIndirectCountCommand.cs

@@ -2,7 +2,7 @@
 {
     struct DrawIndirectCountCommand : IGALCommand, IGALCommand<DrawIndirectCountCommand>
     {
-        public CommandType CommandType => CommandType.DrawIndirectCount;
+        public readonly CommandType CommandType => CommandType.DrawIndirectCount;
         private BufferRange _indirectBuffer;
         private BufferRange _parameterBuffer;
         private int _maxDrawCount;

src/Ryujinx.Graphics.GAL/Multithreading/Commands/DrawTextureCommand.cs

@@ -5,7 +5,7 @@ namespace Ryujinx.Graphics.GAL.Multithreading.Commands
 {
     struct DrawTextureCommand : IGALCommand, IGALCommand<DrawTextureCommand>
     {
-        public CommandType CommandType => CommandType.DrawTexture;
+        public readonly CommandType CommandType => CommandType.DrawTexture;
         private TableRef<ITexture> _texture;
         private TableRef<ISampler> _sampler;
         private Extents2DF _srcRegion;

src/Ryujinx.Graphics.GAL/Multithreading/Commands/EndHostConditionalRenderingCommand.cs

@@ -2,7 +2,7 @@
 {
     struct EndHostConditionalRenderingCommand : IGALCommand, IGALCommand<EndHostConditionalRenderingCommand>
     {
-        public CommandType CommandType => CommandType.EndHostConditionalRendering;
+        public readonly CommandType CommandType => CommandType.EndHostConditionalRendering;
 
         public static void Run(ref EndHostConditionalRenderingCommand command, ThreadedRenderer threaded, IRenderer renderer)
         {

src/Ryujinx.Graphics.GAL/Multithreading/Commands/EndTransformFeedbackCommand.cs

@@ -2,7 +2,7 @@
 {
     struct EndTransformFeedbackCommand : IGALCommand, IGALCommand<EndTransformFeedbackCommand>
     {
-        public CommandType CommandType => CommandType.EndTransformFeedback;
+        public readonly CommandType CommandType => CommandType.EndTransformFeedback;
 
         public static void Run(ref EndTransformFeedbackCommand command, ThreadedRenderer threaded, IRenderer renderer)
         {

src/Ryujinx.Graphics.GAL/Multithreading/Commands/Program/ProgramCheckLinkCommand.cs

@@ -5,7 +5,7 @@ namespace Ryujinx.Graphics.GAL.Multithreading.Commands.Program
 {
     struct ProgramCheckLinkCommand : IGALCommand, IGALCommand<ProgramCheckLinkCommand>
     {
-        public CommandType CommandType => CommandType.ProgramCheckLink;
+        public readonly CommandType CommandType => CommandType.ProgramCheckLink;
         private TableRef<ThreadedProgram> _program;
         private bool _blocking;
         private TableRef<ResultBox<ProgramLinkStatus>> _result;

src/Ryujinx.Graphics.GAL/Multithreading/Commands/Program/ProgramDisposeCommand.cs

@@ -5,7 +5,7 @@ namespace Ryujinx.Graphics.GAL.Multithreading.Commands.Program
 {
     struct ProgramDisposeCommand : IGALCommand, IGALCommand<ProgramDisposeCommand>
     {
-        public CommandType CommandType => CommandType.ProgramDispose;
+        public readonly CommandType CommandType => CommandType.ProgramDispose;
         private TableRef<ThreadedProgram> _program;
 
         public void Set(TableRef<ThreadedProgram> program)

src/Ryujinx.Graphics.GAL/Multithreading/Commands/Program/ProgramGetBinaryCommand.cs

@@ -5,7 +5,7 @@ namespace Ryujinx.Graphics.GAL.Multithreading.Commands.Program
 {
     struct ProgramGetBinaryCommand : IGALCommand, IGALCommand<ProgramGetBinaryCommand>
     {
-        public CommandType CommandType => CommandType.ProgramGetBinary;
+        public readonly CommandType CommandType => CommandType.ProgramGetBinary;
         private TableRef<ThreadedProgram> _program;
         private TableRef<ResultBox<byte[]>> _result;
 

src/Ryujinx.Graphics.GAL/Multithreading/Commands/Renderer/ActionCommand.cs

@@ -5,7 +5,7 @@ namespace Ryujinx.Graphics.GAL.Multithreading.Commands.Renderer
 {
     struct ActionCommand : IGALCommand, IGALCommand<ActionCommand>
     {
-        public CommandType CommandType => CommandType.Action;
+        public readonly CommandType CommandType => CommandType.Action;
         private TableRef<Action> _action;
 
         public void Set(TableRef<Action> action)

src/Ryujinx.Graphics.GAL/Multithreading/Commands/Renderer/CreateBufferAccessCommand.cs

@@ -2,7 +2,7 @@
 {
     struct CreateBufferAccessCommand : IGALCommand, IGALCommand<CreateBufferAccessCommand>
     {
-        public CommandType CommandType => CommandType.CreateBufferAccess;
+        public readonly CommandType CommandType => CommandType.CreateBufferAccess;
         private BufferHandle _threadedHandle;
         private int _size;
         private BufferAccess _access;

src/Ryujinx.Graphics.GAL/Multithreading/Commands/Renderer/CreateBufferCommand.cs

@@ -2,7 +2,7 @@
 {
     struct CreateBufferCommand : IGALCommand, IGALCommand<CreateBufferCommand>
     {
-        public CommandType CommandType => CommandType.CreateBuffer;
+        public readonly CommandType CommandType => CommandType.CreateBuffer;
         private BufferHandle _threadedHandle;
         private int _size;
         private BufferHandle _storageHint;

src/Ryujinx.Graphics.GAL/Multithreading/Commands/Renderer/CreateHostBufferCommand.cs

@@ -2,7 +2,7 @@
 {
     struct CreateHostBufferCommand : IGALCommand, IGALCommand<CreateHostBufferCommand>
     {
-        public CommandType CommandType => CommandType.CreateHostBuffer;
+        public readonly CommandType CommandType => CommandType.CreateHostBuffer;
         private BufferHandle _threadedHandle;
         private nint _pointer;
         private int _size;

src/Ryujinx.Graphics.GAL/Multithreading/Commands/Renderer/CreateProgramCommand.cs

@@ -5,7 +5,7 @@ namespace Ryujinx.Graphics.GAL.Multithreading.Commands.Renderer
 {
     struct CreateProgramCommand : IGALCommand, IGALCommand<CreateProgramCommand>
     {
-        public CommandType CommandType => CommandType.CreateProgram;
+        public readonly CommandType CommandType => CommandType.CreateProgram;
         private TableRef<IProgramRequest> _request;
 
         public void Set(TableRef<IProgramRequest> request)

src/Ryujinx.Graphics.GAL/Multithreading/Commands/Renderer/CreateSamplerCommand.cs

@@ -5,7 +5,7 @@ namespace Ryujinx.Graphics.GAL.Multithreading.Commands.Renderer
 {
     struct CreateSamplerCommand : IGALCommand, IGALCommand<CreateSamplerCommand>
     {
-        public CommandType CommandType => CommandType.CreateSampler;
+        public readonly CommandType CommandType => CommandType.CreateSampler;
         private TableRef<ThreadedSampler> _sampler;
         private SamplerCreateInfo _info;
 

src/Ryujinx.Graphics.GAL/Multithreading/Commands/Renderer/CreateSyncCommand.cs

@@ -2,7 +2,7 @@
 {
     struct CreateSyncCommand : IGALCommand, IGALCommand<CreateSyncCommand>
     {
-        public CommandType CommandType => CommandType.CreateSync;
+        public readonly CommandType CommandType => CommandType.CreateSync;
         private ulong _id;
         private bool _strict;
 

src/Ryujinx.Graphics.GAL/Multithreading/Commands/Renderer/CreateTextureCommand.cs

@@ -5,7 +5,7 @@ namespace Ryujinx.Graphics.GAL.Multithreading.Commands.Renderer
 {
     struct CreateTextureCommand : IGALCommand, IGALCommand<CreateTextureCommand>
     {
-        public CommandType CommandType => CommandType.CreateTexture;
+        public readonly CommandType CommandType => CommandType.CreateTexture;
         private TableRef<ThreadedTexture> _texture;
         private TextureCreateInfo _info;
         private float _scale;

src/Ryujinx.Graphics.GAL/Multithreading/Commands/Renderer/GetCapabilitiesCommand.cs

@@ -4,7 +4,7 @@ namespace Ryujinx.Graphics.GAL.Multithreading.Commands.Renderer
 {
     struct GetCapabilitiesCommand : IGALCommand, IGALCommand<GetCapabilitiesCommand>
     {
-        public CommandType CommandType => CommandType.GetCapabilities;
+        public readonly CommandType CommandType => CommandType.GetCapabilities;
         private TableRef<ResultBox<Capabilities>> _result;
 
         public void Set(TableRef<ResultBox<Capabilities>> result)

src/Ryujinx.Graphics.GAL/Multithreading/Commands/Renderer/PreFrameCommand.cs

@@ -2,7 +2,7 @@
 {
     struct PreFrameCommand : IGALCommand, IGALCommand<PreFrameCommand>
     {
-        public CommandType CommandType => CommandType.PreFrame;
+        public readonly CommandType CommandType => CommandType.PreFrame;
 
         public static void Run(ref PreFrameCommand command, ThreadedRenderer threaded, IRenderer renderer)
         {

src/Ryujinx.Graphics.GAL/Multithreading/Commands/Renderer/ReportCounterCommand.cs

@@ -6,7 +6,7 @@ namespace Ryujinx.Graphics.GAL.Multithreading.Commands.Renderer
 {
     struct ReportCounterCommand : IGALCommand, IGALCommand<ReportCounterCommand>
     {
-        public CommandType CommandType => CommandType.ReportCounter;
+        public readonly CommandType CommandType => CommandType.ReportCounter;
         private TableRef<ThreadedCounterEvent> _event;
         private CounterType _type;
         private TableRef<EventHandler<ulong>> _resultHandler;

src/Ryujinx.Graphics.GAL/Multithreading/Commands/Renderer/ResetCounterCommand.cs

@@ -2,7 +2,7 @@
 {
     struct ResetCounterCommand : IGALCommand, IGALCommand<ResetCounterCommand>
     {
-        public CommandType CommandType => CommandType.ResetCounter;
+        public readonly CommandType CommandType => CommandType.ResetCounter;
         private CounterType _type;
 
         public void Set(CounterType type)

src/Ryujinx.Graphics.GAL/Multithreading/Commands/Renderer/UpdateCountersCommand.cs

@@ -2,7 +2,7 @@
 {
     struct UpdateCountersCommand : IGALCommand, IGALCommand<UpdateCountersCommand>
     {
-        public CommandType CommandType => CommandType.UpdateCounters;
+        public readonly CommandType CommandType => CommandType.UpdateCounters;
 
         public static void Run(ref UpdateCountersCommand command, ThreadedRenderer threaded, IRenderer renderer)
         {

src/Ryujinx.Graphics.GAL/Multithreading/Commands/Sampler/SamplerDisposeCommand.cs

@@ -5,7 +5,7 @@ namespace Ryujinx.Graphics.GAL.Multithreading.Commands.Sampler
 {
     struct SamplerDisposeCommand : IGALCommand, IGALCommand<SamplerDisposeCommand>
     {
-        public CommandType CommandType => CommandType.SamplerDispose;
+        public readonly CommandType CommandType => CommandType.SamplerDispose;
         private TableRef<ThreadedSampler> _sampler;
 
         public void Set(TableRef<ThreadedSampler> sampler)

src/Ryujinx.Graphics.GAL/Multithreading/Commands/SetAlphaTestCommand.cs

@@ -2,7 +2,7 @@
 {
     struct SetAlphaTestCommand : IGALCommand, IGALCommand<SetAlphaTestCommand>
     {
-        public CommandType CommandType => CommandType.SetAlphaTest;
+        public readonly CommandType CommandType => CommandType.SetAlphaTest;
         private bool _enable;
         private float _reference;
         private CompareOp _op;

src/Ryujinx.Graphics.GAL/Multithreading/Commands/SetBlendStateAdvancedCommand.cs

@@ -2,7 +2,7 @@ namespace Ryujinx.Graphics.GAL.Multithreading.Commands
 {
     struct SetBlendStateAdvancedCommand : IGALCommand, IGALCommand<SetBlendStateAdvancedCommand>
     {
-        public CommandType CommandType => CommandType.SetBlendStateAdvanced;
+        public readonly CommandType CommandType => CommandType.SetBlendStateAdvanced;
         private AdvancedBlendDescriptor _blend;
 
         public void Set(AdvancedBlendDescriptor blend)

src/Ryujinx.Graphics.GAL/Multithreading/Commands/SetBlendStateCommand.cs

@@ -2,7 +2,7 @@
 {
     struct SetBlendStateCommand : IGALCommand, IGALCommand<SetBlendStateCommand>
     {
-        public CommandType CommandType => CommandType.SetBlendState;
+        public readonly CommandType CommandType => CommandType.SetBlendState;
         private int _index;
         private BlendDescriptor _blend;
 

src/Ryujinx.Graphics.GAL/Multithreading/Commands/SetDepthBiasCommand.cs

@@ -2,7 +2,7 @@
 {
     struct SetDepthBiasCommand : IGALCommand, IGALCommand<SetDepthBiasCommand>
     {
-        public CommandType CommandType => CommandType.SetDepthBias;
+        public readonly CommandType CommandType => CommandType.SetDepthBias;
         private PolygonModeMask _enables;
         private float _factor;
         private float _units;

src/Ryujinx.Graphics.GAL/Multithreading/Commands/SetDepthClampCommand.cs

@@ -2,7 +2,7 @@
 {
     struct SetDepthClampCommand : IGALCommand, IGALCommand<SetDepthClampCommand>
     {
-        public CommandType CommandType => CommandType.SetDepthClamp;
+        public readonly CommandType CommandType => CommandType.SetDepthClamp;
         private bool _clamp;
 
         public void Set(bool clamp)

src/Ryujinx.Graphics.GAL/Multithreading/Commands/SetDepthModeCommand.cs

@@ -2,7 +2,7 @@
 {
     struct SetDepthModeCommand : IGALCommand, IGALCommand<SetDepthModeCommand>
     {
-        public CommandType CommandType => CommandType.SetDepthMode;
+        public readonly CommandType CommandType => CommandType.SetDepthMode;
         private DepthMode _mode;
 
         public void Set(DepthMode mode)

src/Ryujinx.Graphics.GAL/Multithreading/Commands/SetDepthTestCommand.cs

@@ -2,7 +2,7 @@
 {
     struct SetDepthTestCommand : IGALCommand, IGALCommand<SetDepthTestCommand>
     {
-        public CommandType CommandType => CommandType.SetDepthTest;
+        public readonly CommandType CommandType => CommandType.SetDepthTest;
         private DepthTestDescriptor _depthTest;
 
         public void Set(DepthTestDescriptor depthTest)

src/Ryujinx.Graphics.GAL/Multithreading/Commands/SetFaceCullingCommand.cs

@@ -2,7 +2,7 @@
 {
     struct SetFaceCullingCommand : IGALCommand, IGALCommand<SetFaceCullingCommand>
     {
-        public CommandType CommandType => CommandType.SetFaceCulling;
+        public readonly CommandType CommandType => CommandType.SetFaceCulling;
         private bool _enable;
         private Face _face;
 

src/Ryujinx.Graphics.GAL/Multithreading/Commands/SetFrontFaceCommand.cs

@@ -2,7 +2,7 @@
 {
     struct SetFrontFaceCommand : IGALCommand, IGALCommand<SetFrontFaceCommand>
     {
-        public CommandType CommandType => CommandType.SetFrontFace;
+        public readonly CommandType CommandType => CommandType.SetFrontFace;
         private FrontFace _frontFace;
 
         public void Set(FrontFace frontFace)

src/Ryujinx.Graphics.GAL/Multithreading/Commands/SetImageCommand.cs

@@ -5,7 +5,7 @@ namespace Ryujinx.Graphics.GAL.Multithreading.Commands
 {
     struct SetImageCommand : IGALCommand, IGALCommand<SetImageCommand>
     {
-        public CommandType CommandType => CommandType.SetImage;
+        public readonly CommandType CommandType => CommandType.SetImage;
         private int _binding;
         private TableRef<ITexture> _texture;
         private Format _imageFormat;

src/Ryujinx.Graphics.GAL/Multithreading/Commands/SetIndexBufferCommand.cs

@@ -2,7 +2,7 @@
 {
     struct SetIndexBufferCommand : IGALCommand, IGALCommand<SetIndexBufferCommand>
     {
-        public CommandType CommandType => CommandType.SetIndexBuffer;
+        public readonly CommandType CommandType => CommandType.SetIndexBuffer;
         private BufferRange _buffer;
         private IndexType _type;
 

src/Ryujinx.Graphics.GAL/Multithreading/Commands/SetLineParametersCommand.cs

@@ -2,7 +2,7 @@
 {
     struct SetLineParametersCommand : IGALCommand, IGALCommand<SetLineParametersCommand>
     {
-        public CommandType CommandType => CommandType.SetLineParameters;
+        public readonly CommandType CommandType => CommandType.SetLineParameters;
         private float _width;
         private bool _smooth;
 

src/Ryujinx.Graphics.GAL/Multithreading/Commands/SetLogicOpStateCommand.cs

@@ -2,7 +2,7 @@
 {
     struct SetLogicOpStateCommand : IGALCommand, IGALCommand<SetLogicOpStateCommand>
     {
-        public CommandType CommandType => CommandType.SetLogicOpState;
+        public readonly CommandType CommandType => CommandType.SetLogicOpState;
         private bool _enable;
         private LogicalOp _op;
 

src/Ryujinx.Graphics.GAL/Multithreading/Commands/SetMultisampleStateCommand.cs

@@ -2,7 +2,7 @@ namespace Ryujinx.Graphics.GAL.Multithreading.Commands
 {
     struct SetMultisampleStateCommand : IGALCommand, IGALCommand<SetMultisampleStateCommand>
     {
-        public CommandType CommandType => CommandType.SetMultisampleState;
+        public readonly CommandType CommandType => CommandType.SetMultisampleState;
         private MultisampleDescriptor _multisample;
 
         public void Set(MultisampleDescriptor multisample)

src/Ryujinx.Graphics.GAL/Multithreading/Commands/SetPatchParametersCommand.cs

@@ -5,7 +5,7 @@ namespace Ryujinx.Graphics.GAL.Multithreading.Commands
 {
     struct SetPatchParametersCommand : IGALCommand, IGALCommand<SetPatchParametersCommand>
     {
-        public CommandType CommandType => CommandType.SetPatchParameters;
+        public readonly CommandType CommandType => CommandType.SetPatchParameters;
         private int _vertices;
         private Array4<float> _defaultOuterLevel;
         private Array2<float> _defaultInnerLevel;

src/Ryujinx.Graphics.GAL/Multithreading/Commands/SetPointParametersCommand.cs

@@ -2,7 +2,7 @@
 {
     struct SetPointParametersCommand : IGALCommand, IGALCommand<SetPointParametersCommand>
     {
-        public CommandType CommandType => CommandType.SetPointParameters;
+        public readonly CommandType CommandType => CommandType.SetPointParameters;
         private float _size;
         private bool _isProgramPointSize;
         private bool _enablePointSprite;

src/Ryujinx.Graphics.GAL/Multithreading/Commands/SetPolygonModeCommand.cs

@@ -2,7 +2,7 @@ namespace Ryujinx.Graphics.GAL.Multithreading.Commands
 {
     struct SetPolygonModeCommand : IGALCommand, IGALCommand<SetPolygonModeCommand>
     {
-        public CommandType CommandType => CommandType.SetPolygonMode;
+        public readonly CommandType CommandType => CommandType.SetPolygonMode;
         private PolygonMode _frontMode;
         private PolygonMode _backMode;
 

src/Ryujinx.Graphics.GAL/Multithreading/Commands/SetPrimitiveRestartCommand.cs

@@ -2,7 +2,7 @@
 {
     struct SetPrimitiveRestartCommand : IGALCommand, IGALCommand<SetPrimitiveRestartCommand>
     {
-        public CommandType CommandType => CommandType.SetPrimitiveRestart;
+        public readonly CommandType CommandType => CommandType.SetPrimitiveRestart;
         private bool _enable;
         private int _index;
 

src/Ryujinx.Graphics.GAL/Multithreading/Commands/SetPrimitiveTopologyCommand.cs

@@ -2,7 +2,7 @@
 {
     struct SetPrimitiveTopologyCommand : IGALCommand, IGALCommand<SetPrimitiveTopologyCommand>
     {
-        public CommandType CommandType => CommandType.SetPrimitiveTopology;
+        public readonly CommandType CommandType => CommandType.SetPrimitiveTopology;
         private PrimitiveTopology _topology;
 
         public void Set(PrimitiveTopology topology)

src/Ryujinx.Graphics.GAL/Multithreading/Commands/SetProgramCommand.cs

@@ -5,7 +5,7 @@ namespace Ryujinx.Graphics.GAL.Multithreading.Commands
 {
     struct SetProgramCommand : IGALCommand, IGALCommand<SetProgramCommand>
     {
-        public CommandType CommandType => CommandType.SetProgram;
+        public readonly CommandType CommandType => CommandType.SetProgram;
         private TableRef<IProgram> _program;
 
         public void Set(TableRef<IProgram> program)