Perform bounds checking before list indexer to avoid frequent exceptions (#4438)

* Perform bounds checking before list indexer to avoid frequent ArgumentOutOfRangeExceptions

* do a single compare after casting id and .Count to uint

Ryujinx.Ava/UI/ViewModels/TitleUpdateViewModel.cs

@@ -105,13 +105,13 @@ public class TitleUpdateViewModel : BaseModel
             AddUpdate(path);
         }
 
-        // NOTE: Save the list again to remove leftovers.
-        Save();
-
         TitleUpdateModel selected = TitleUpdates.FirstOrDefault(x => x.Path == _titleUpdateWindowData.Selected, null);
 
         SelectedUpdate = selected;
 
+        // NOTE: Save the list again to remove leftovers.
+        Save();
+
         SortUpdates();
     }
 

Ryujinx.Graphics.Gpu/Engine/Threed/StateUpdater.cs

@@ -439,7 +439,7 @@ namespace Ryujinx.Graphics.Gpu.Engine.Threed
             int samplesInY = msaaMode.SamplesInY();
 
             var scissor = _state.State.ScreenScissorState;
-            Size sizeHint = new Size(scissor.X + scissor.Width, scissor.Y + scissor.Height, 1);
+            Size sizeHint = new Size((scissor.X + scissor.Width) * samplesInX, (scissor.Y + scissor.Height) * samplesInY, 1);
 
             int clipRegionWidth = int.MaxValue;
             int clipRegionHeight = int.MaxValue;

Ryujinx.Graphics.Vulkan/IdList.cs

@@ -79,10 +79,18 @@ namespace Ryujinx.Graphics.Vulkan
             id--;
 
             try
+            {
+                if ((uint)id < (uint)_list.Count)
                 {
                     value = _list[id];
                     return value != null;
                 }
+                else
+                {
+                    value = null;
+                    return false;
+                }
+            }
             catch (ArgumentOutOfRangeException)
             {
                 value = null;