[Ryujinx.Audio] Address dotnet-format issues (#5362)

* dotnet format style --severity info

Some changes were manually reverted.

* dotnet format analyzers --serverity info

Some changes have been minimally adapted.

* Restore a few unused methods and variables

* Silence dotnet format IDE0060 warnings

* Silence dotnet format IDE0052 warnings

* Address dotnet format CA1816 warnings

* Address or silence dotnet format CA2208 warnings

* Address or silence dotnet format CA2211 warnings

* Address review comments

* Address most dotnet format whitespace warnings

* Apply dotnet format whitespace formatting

A few of them have been manually reverted and the corresponding warning was silenced

* Format if-blocks correctly

* Run dotnet format whitespace after rebase

* Run dotnet format after rebase and remove unused usings

- analyzers
- style
- whitespace

* Add comments to disabled warnings

* Remove a few unused parameters

* Simplify properties and array initialization, Use const when possible, Remove trailing commas

* Start working on disabled warnings

* Fix and silence a few dotnet-format warnings again

* Address IDE0251 warnings

* Silence IDE0060 in .editorconfig

* Revert "Simplify properties and array initialization, Use const when possible, Remove trailing commas"

This reverts commit 9462e4136c0a2100dc28b20cf9542e06790aa67e.

* dotnet format whitespace after rebase

* Fix naming rule violations, remove redundant code and fix build issues

* Apply suggestions from code review

Co-authored-by: Ac_K <Acoustik666@gmail.com>

* Add trailing commas

* Apply suggestions from code review

Co-authored-by: Ac_K <Acoustik666@gmail.com>

* Address review feedback

---------

Co-authored-by: Ac_K <Acoustik666@gmail.com>

src/Ryujinx.Audio/Renderer/Server/Splitter/SplitterContext.cs

@@ -101,10 +101,8 @@ namespace Ryujinx.Audio.Renderer.Server.Splitter
 
                 return size;
             }
-            else
-            {
-                return size;
-            }
+
+            return size;
         }
 
         /// <summary>
@@ -164,10 +162,10 @@ namespace Ryujinx.Audio.Renderer.Server.Splitter
                     {
                         ref SplitterState splitter = ref GetState(parameter.Id);
 
-                        splitter.Update(this, ref parameter, input.Slice(Unsafe.SizeOf<SplitterInParameter>()));
+                        splitter.Update(this, ref parameter, input[Unsafe.SizeOf<SplitterInParameter>()..]);
                     }
 
-                    input = input.Slice(0x1C + (int)parameter.DestinationCount * 4);
+                    input = input[(0x1C + parameter.DestinationCount * 4)..];
                 }
             }
         }
@@ -194,7 +192,7 @@ namespace Ryujinx.Audio.Renderer.Server.Splitter
                         destination.Update(parameter);
                     }
 
-                    input = input.Slice(Unsafe.SizeOf<SplitterDestinationInParameter>());
+                    input = input[Unsafe.SizeOf<SplitterDestinationInParameter>()..];
                 }
             }
         }
@@ -229,12 +227,10 @@ namespace Ryujinx.Audio.Renderer.Server.Splitter
 
                 return true;
             }
-            else
-            {
-                consumedSize = 0;
 
-                return false;
-            }
+            consumedSize = 0;
+
+            return false;
         }
 
         /// <summary>
@@ -300,4 +296,4 @@ namespace Ryujinx.Audio.Renderer.Server.Splitter
             }
         }
     }
-}
+}

src/Ryujinx.Audio/Renderer/Server/Splitter/SplitterDestination.cs

@@ -65,7 +65,7 @@ namespace Ryujinx.Audio.Renderer.Server.Splitter
         /// <summary>
         /// Get the  <see cref="Span{SplitterDestination}"/> of the next element or <see cref="Span{SplitterDestination}.Empty"/> if not present.
         /// </summary>
-        public Span<SplitterDestination> Next
+        public readonly Span<SplitterDestination> Next
         {
             get
             {
@@ -138,7 +138,7 @@ namespace Ryujinx.Audio.Renderer.Server.Splitter
         /// Return true if the <see cref="SplitterDestination"/> is used and has a destination.
         /// </summary>
         /// <returns>True if the <see cref="SplitterDestination"/> is used and has a destination.</returns>
-        public bool IsConfigured()
+        public readonly bool IsConfigured()
         {
             return IsUsed && DestinationId != Constants.UnusedMixId;
         }
@@ -160,8 +160,8 @@ namespace Ryujinx.Audio.Renderer.Server.Splitter
         /// </summary>
         public void ClearVolumes()
         {
-            MixBufferVolume.Fill(0);
-            PreviousMixBufferVolume.Fill(0);
+            MixBufferVolume.Clear();
+            PreviousMixBufferVolume.Clear();
         }
 
         /// <summary>
@@ -190,4 +190,4 @@ namespace Ryujinx.Audio.Renderer.Server.Splitter
             }
         }
     }
-}
+}

src/Ryujinx.Audio/Renderer/Server/Splitter/SplitterState.cs

@@ -43,7 +43,7 @@ namespace Ryujinx.Audio.Renderer.Server.Splitter
         /// <summary>
         /// Span to the first element of the linked list of <see cref="SplitterDestination"/>.
         /// </summary>
-        public Span<SplitterDestination> Destinations
+        public readonly Span<SplitterDestination> Destinations
         {
             get
             {
@@ -63,7 +63,7 @@ namespace Ryujinx.Audio.Renderer.Server.Splitter
             Id = id;
         }
 
-        public Span<SplitterDestination> GetData(int index)
+        public readonly Span<SplitterDestination> GetData(int index)
         {
             int i = 0;
 
@@ -95,7 +95,7 @@ namespace Ryujinx.Audio.Renderer.Server.Splitter
         /// Utility function to apply a given <see cref="SpanAction{T, TArg}"/> to all <see cref="Destinations"/>.
         /// </summary>
         /// <param name="action">The action to execute on each elements.</param>
-        private void ForEachDestination(SpanAction<SplitterDestination, int> action)
+        private readonly void ForEachDestination(SpanAction<SplitterDestination, int> action)
         {
             Span<SplitterDestination> temp = Destinations;
 
@@ -183,7 +183,7 @@ namespace Ryujinx.Audio.Renderer.Server.Splitter
         /// <summary>
         /// Update the internal state of this instance.
         /// </summary>
-        public void UpdateInternalState()
+        public readonly void UpdateInternalState()
         {
             ForEachDestination((destination, _) => destination[0].UpdateInternalState());
         }
@@ -218,4 +218,4 @@ namespace Ryujinx.Audio.Renderer.Server.Splitter
             }
         }
     }
-}
+}